Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport][fix][websocket] Connection header must include not match Upgrade #13012

Merged
merged 1 commit into from Nov 5, 2017

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Nov 5, 2017

Description

RFC 6455 4.1. Client Requirements
The request MUST contain a |Connection| header field whose value MUST include the "Upgrade" token.

backports #13001

Motivation and Context

newer Firefox versions send Connection: keep-alive, Upgrade

How Has This Been Tested?

Tested with Firefox 56.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

RFC 6455 4.1. Client Requirements
The request MUST contain a |Connection| header field whose value MUST include the "Upgrade" token.
@Rechi Rechi added Type: Backport Type: Fix non-breaking change which fixes an issue v17 Krypton labels Nov 5, 2017
@Rechi Rechi added this to the Krypton 17.6 milestone Nov 5, 2017
@MartijnKaijser MartijnKaijser merged commit 446c936 into xbmc:Krypton Nov 5, 2017
@Rechi Rechi deleted the websocketKrypton branch November 5, 2017 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Backport Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants