Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[music]Fix sort names for artists that are only album artists #13030

Merged
merged 1 commit into from Nov 11, 2017

Conversation

@DaveTBlake
Copy link
Member

DaveTBlake commented Nov 9, 2017

Artist sort name was not always being correctly retrieved from the ALBUMARTISTSORT tag for some album artists. When the music file did not have Musicbrainz id tags and the artists are only album artists (not the song artist given in the ARTIST tag) the sort name was not being used.

This fix has been tested by users (test build from my repo) and solves the issue that has existed since the feature was added by #11738

Discussed here https://forum.kodi.tv/showthread.php?tid=323013

…tags and artists are only album artists.
@DaveTBlake DaveTBlake added this to the L 18.0-alpha1 milestone Nov 9, 2017
@notspiff

This comment has been minimized.

Copy link
Contributor

notspiff commented Nov 11, 2017

looks fine.

@DaveTBlake DaveTBlake merged commit d97dc60 into xbmc:master Nov 11, 2017
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@DaveTBlake DaveTBlake deleted the DaveTBlake:AlbumArtistOnlySort branch Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.