Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[music]Fix sort names for artists that are only album artists #13030

Merged
merged 1 commit into from
Nov 11, 2017

Conversation

DaveTBlake
Copy link
Member

@DaveTBlake DaveTBlake commented Nov 9, 2017

Artist sort name was not always being correctly retrieved from the ALBUMARTISTSORT tag for some album artists. When the music file did not have Musicbrainz id tags and the artists are only album artists (not the song artist given in the ARTIST tag) the sort name was not being used.

This fix has been tested by users (test build from my repo) and solves the issue that has existed since the feature was added by #11738

Discussed here https://forum.kodi.tv/showthread.php?tid=323013

@DaveTBlake DaveTBlake added Type: Fix non-breaking change which fixes an issue Component: Music v18 Leia labels Nov 9, 2017
@DaveTBlake DaveTBlake added this to the L 18.0-alpha1 milestone Nov 9, 2017
@notspiff
Copy link
Contributor

looks fine.

@DaveTBlake DaveTBlake merged commit d97dc60 into xbmc:master Nov 11, 2017
@DaveTBlake DaveTBlake deleted the AlbumArtistOnlySort branch November 11, 2017 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Music Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants