Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added: allow vfs-addons to populate network setup dialog #13038

Merged
merged 1 commit into from
Nov 13, 2017
Merged

added: allow vfs-addons to populate network setup dialog #13038

merged 1 commit into from
Nov 13, 2017

Conversation

notspiff
Copy link
Contributor

see title.

@notspiff notspiff mentioned this pull request Nov 11, 2017
Closed
xhaggi
xhaggi reviewed Nov 12, 2017
View reviewed changes
xbmc/addons/VFSEntry.cpp Outdated
supportUsername(addonInfo->Type(ADDON_VFS)->GetValue("@usernameSupport").asBoolean()),
supportPassword(addonInfo->Type(ADDON_VFS)->GetValue("@passwordSupport").asBoolean()),
supportPort(addonInfo->Type(ADDON_VFS)->GetValue("@portSupport").asBoolean()),
supportBrowsing(addonInfo->Type(ADDON_VFS)->GetValue("@browsingSupport").asBoolean()),

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

xhaggi
xhaggi reviewed Nov 12, 2017
View reviewed changes
xbmc/addons/VFSEntry.cpp Outdated
supportBrowsing(addonInfo->Type(ADDON_VFS)->GetValue("@browsingSupport").asBoolean()),
defaultPort(addonInfo->Type(ADDON_VFS)->GetValue("@defaultPort").asInteger()),
type(addonInfo->Type(ADDON_VFS)->GetValue("@protocols").asString()),
label(addonInfo->Type(ADDON_VFS)->GetValue("@labelID").asInteger())

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

xhaggi
xhaggi reviewed Nov 12, 2017
View reviewed changes
xbmc/network/GUIDialogNetworkSetup.cpp Outdated
@@ -226,6 +226,16 @@ void CGUIDialogNetworkSetup::InitializeSettings()
m_protocols.emplace_back(Protocol{true, true, true, true, false, 22, "sftp", 20260});
#endif

for (const auto& addon : CServiceBroker::GetVFSAddonCache().GetAddonInstances())

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

xhaggi
xhaggi approved these changes Nov 13, 2017
View reviewed changes
Copy link
Member

@xhaggi xhaggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@notspiff
Copy link
Contributor Author

jenkins build this please

@notspiff notspiff merged commit 21169ac into xbmc:master Nov 13, 2017
@notspiff notspiff deleted the vfs_network_dialog branch November 13, 2017 12:06
@Rechi Rechi added Component: Binary add-ons Type: Improvement non-breaking change which improves existing functionality v18 Leia labels Nov 13, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Nov 13, 2017
notspiff referenced this pull request in afedchin/vfs.smb1 Nov 17, 2017
@afedchin
initial commit
867f97f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhaggi xhaggi xhaggi approved these changes

Assignees
No one assigned
Labels
Component: Binary add-ons Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@notspiff @xhaggi @Rechi