[PVR] PVR client cleanup and improvement #13040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
ksooo
force-pushed
the
pvr-client-addon-calls
branch
from
5d2c7cf
to
5b54914
Compare
|
jenkins build this please |
FernetMenta
approved these changes
Nov 12, 2017
There was a problem hiding this comment.
looks sane imo. but I think this is going to be obsolete after we split pvr and streaming api. not sure about the status of @AlwinEsch 's work
|
I don't think this will be obsolete, as it makes sense as long as you have a PVR API with more than one function, which will be still the case, even after we rip off inputstream functions. |
|
I'm not aware that Alwin is working on the API split, btw. |
|
@ksooo before the API can be split the PVR addon has to be migrated to the new design. That I hoped @AlwinEsch was working on. |
Ah, okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is a larger cleanup and routes all calls to the client addon through a single proxy method. So, common tasks before after the client addon call can be held in one place . The diff is large, thus not easy to read. Take a look at a good example snippet, to get the idea: 2a62ed2#diff-d63034db2a0e41f8c4bf14542b168cd4L569
Second commit improves pvr manager shutdown performance. I've seen cases before where the client addon could not reach the backend (network problems, misconfiguration, ...) and pvr manager shutdown took ages, because it had to wait for the timeouts for a bunch of backend calls ongoing while pvr manager should be shut down - pvr gui info thread updating backend data cache and calling several client addon methods in a row is one of the candidates causing this.
This changes are runtime-tested on macOS, latest Kodi master.
@FernetMenta for review?