Fix Back button in Android TV Remote Control app #13049
Conversation
garbear
added
Type: Fix
garbear
force-pushed
the
joystick-back
branch
from
8626322
to
f52a41e
Compare
|
jenkins build this please |
Previously, pressing B would immediately stop the video. After changing this to match the Backspace key behavior, pressing B will toggle fullscreen and holding B will stop.
This makes the B button mirror the behavior of the Backspace key.
garbear
force-pushed
the
joystick-back
branch
from
f52a41e
to
0e6f395
Compare
|
That would be a great improvement, yes. |
|
@bb10 I raised your idea on the forum thread: https://forum.kodi.tv/showthread.php?tid=308480&pid=2795177#pid2795177 Just to see what others think. I'm for switching the two like you proposed. |
|
Any update on this? Would be a shame if this made it into the final v18 release. |
|
Can you open a PR with the ideas suggested in the thread? I can't until this weekend, so to hit v18 it should be opened today. |
|
I hope I did this right, it's my first PR. I did not feel comfortable changing the keyboard.xml atm. I guess we could just change it and see if anyone complains and revert it in a point release if anyone does? The problem is that CiNcH somehow expects B and backspace to behave the same, but they never have and any changes to them will be breaking for any keyboard and joystick users. Let me know what you think. 😃 |
The Back button shows up as a joystick button, which is mapped to the B button in xbmc/peripheral.joystick#129 (and backported to Krypton).
This PR makes the B button behave like the Backspace button on a keyboard, which is how the button is interpreted when peripheral.joystick is disabled. Now, the Back button should work the same whether it's operating as a joystick or keyboard.
This required two steps: changing joystick.xml to match keyboard.xml and fixing a joystick bug. The bug caused the FullscreenVideo window to close immediately upon reopening from the Home screen.
Motivation and Context
Reported here: https://forum.kodi.tv/showthread.php?tid=308480&pid=2667452#pid2667452
How Has This Been Tested?
Screenshots (if appropriate):
Android TV Remote Control:
Types of change