smbclient changes for smb minprotocol and legacysecurity

[chewitt]

Description

Support feedback from LE8.2 shows a need for client min protocol to ensure smbclient can never make SMB1 connections to some servers. We've also had users report issues with older routers and NAS boxes that contain ancient Samba versions for USB drive sharing that cannot handle NTLMv2 so the "legacy security" option (only visible when max protocol is SMB1) allows older NTLM(v1) auth for compatibility.

How Has This Been Tested?

Krypton versions of the same patch are in LE 8.2.1 which has been tested over the last week. These are the same changes tweaked for different CSettings in Leia.

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the Code guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the CONTRIBUTING document
• I have added tests to cover my change
• All new and existing tests passed

[MartijnKaijser]

Any objections?

[jenkins4kodi]

@chewitt this needs a rebase

[chewitt]

Rebased and good to merge. We've had this change in LE 8.2.1/8.2.2 without any reported issues and it allows users to self-resolve a few more SMB corner cases.