Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smbclient changes for smb minprotocol and legacysecurity #13062

Merged
merged 1 commit into from Jan 6, 2018

Conversation

@chewitt
Copy link
Member

commented Nov 18, 2017

Description

Support feedback from LE8.2 shows a need for client min protocol to ensure smbclient can never make SMB1 connections to some servers. We've also had users report issues with older routers and NAS boxes that contain ancient Samba versions for USB drive sharing that cannot handle NTLMv2 so the "legacy security" option (only visible when max protocol is SMB1) allows older NTLM(v1) auth for compatibility.

How Has This Been Tested?

Krypton versions of the same patch are in LE 8.2.1 which has been tested over the last week. These are the same changes tweaked for different CSettings in Leia.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Dec 17, 2017

Any objections?

@jenkins4kodi

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2018

@chewitt this needs a rebase

@chewitt chewitt force-pushed the chewitt:smbclient_leia branch from a8140f1 to 209fec3 Jan 6, 2018

@Rechi Rechi removed the Rebase needed label Jan 6, 2018

@chewitt chewitt force-pushed the chewitt:smbclient_leia branch from 209fec3 to 07e4daa Jan 6, 2018

@chewitt

This comment has been minimized.

Copy link
Member Author

commented Jan 6, 2018

Rebased and good to merge. We've had this change in LE 8.2.1/8.2.2 without any reported issues and it allows users to self-resolve a few more SMB corner cases.

@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Jan 6, 2018

@MartijnKaijser MartijnKaijser merged commit 0d73351 into xbmc:master Jan 6, 2018

1 check passed

default You're awesome. Have a cookie
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.