[PVR][keymaps][guiinfo] Fix / improve subchannel numbers support #13069
Conversation
ksooo
added
Type: Cleanup
xbmc/pvr/PVRGUIActions.cpp
Outdated
| bool bSwitchToPreviousChannel; | ||
| { | ||
| CSingleLock lock(m_mutex); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Definitely a change for the better |
ksooo
force-pushed
the
pvr-subchannelnumbers
branch
from
99b69d2
to
a9c3134
Compare
| auto it = m_members.find(id); | ||
| return it != m_members.end() ? | ||
| it->second : | ||
| CPVRChannelGroup::EmptyMember; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good +1 |
…r (was set from several places, but never read.
…nto CPVRChannelNumber.
…yer.SubChannelNumber, VideoPlayer.ChannelNumber, VideoPlayer.SubChannelNumber, ListItem.ChannelNumber, ListItem.SubChannelNumber. All were long time ago replaced by MusicPlayer.ChannelNumberLabel, VideoPlayer.ChannelNumberLabel, ListItem.ChannelNumberLabel. Time to cleanup now.
… -> *_CHANNEL_NUMBER.
ksooo
force-pushed
the
pvr-subchannelnumbers
branch
from
a9c3134
to
658b2ba
Compare
|
Jenkins LINUX-64-Wayland testsuite crash on exit seems unrelated. |
|
@ksooo alls jenkins builds are failings since this got merged |
|
For the PR itself, only Linux 64 wayland was failing, as I wrote... |
|
Linux 64 wayland is the one which failed for every build |
|
You wrote "all Jenkins builds are failing"... ;-) |
| if (pos != 0) | ||
| { | ||
| iChannelNumber = std::atoi(m_inputBuffer.substr(0, pos).c_str()); | ||
| if (pos != m_inputBuffer.back()) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Support for (ATSC) subchannel numbers was very limited and buggy. This PR does not make things perfect, but heads into the right direction to complete the support.
Direct channel number input:
All changes are runtime-tested on macOS, latest Kodi master.
@Jalle19 do you want to do the code review?
@ronie headsup for the removed guiinfo labels (no todos for Estuary/Estouchy/Confluence).