[JSON-RPC]Add "art" parameter to audio library Get and Set methods #13101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both get and set any type of artwork for each media type (artists, albums and songs)
DaveTBlake
added
Type: Improvement
|
Thanks Dave! Stuff and stuff and mumbles. Edit: These concerns weren't directly related to this PR and moved to the forum thread. This PR LGTM, as an API consumer. |
|
would like to get this one in. tested and works ok for me. |
|
Thanks for testing @ronie, I would like it merged too. I have been waiting approveal from @Montellese of JSON API syntax, but I fear he is too busy with real life. It follows all the API principles he has previous set out, so after a month is the team prepared to trust my competence and merge without that? |
|
thx! |
|
@DaveTBlake you made a new best friend now since ronie wanted this since i joined the team :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "art" parameter to audio library Get and Set methods. Both get and set any type of artwork for each media type (artists, albums and songs).
Requested numerous times, this brings the functionality inline with that of the video library. For example see https://forum.kodi.tv/showthread.php?tid=324170
A test version is available on the mirrors
@Montellese sorry to bother you again, but this one is more straight forwards.
Interface addition, hence minor version bump to 9.1.0