Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] PVR manager: last PVR core component is now free from GUI code. #13141

Merged
merged 2 commits into from
Dec 7, 2017

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Dec 6, 2017

Moved the last GUI code from PVR Manager to PVR GUI Actions, no functional changes.

I runtime-tested the changes on macOS, latest Kodi master.

@Jalle19 mind taking a look.

@ksooo ksooo added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Component: PVR v18 Leia labels Dec 6, 2017
@ksooo ksooo added this to the L 18.0-alpha1 milestone Dec 6, 2017
@ksooo ksooo requested a review from Jalle19 December 6, 2017 14:04
@xhaggi
Copy link
Member

xhaggi commented Dec 6, 2017

Looks good

@xhaggi
Copy link
Member

xhaggi commented Dec 6, 2017

Second commit looks good too.

@ksooo ksooo force-pushed the pvr-remove-gui-stuff-from-pvr-manager branch 2 times, most recently from c0c4862 to cc0a8af Compare December 6, 2017 21:16
@ksooo
Copy link
Member Author

ksooo commented Dec 6, 2017

Added doxy for the methods added to CPVRGUIActions.

@ksooo ksooo force-pushed the pvr-remove-gui-stuff-from-pvr-manager branch from cc0a8af to d5ec993 Compare December 6, 2017 21:57
@ksooo ksooo merged commit a965075 into xbmc:master Dec 7, 2017
@ksooo ksooo deleted the pvr-remove-gui-stuff-from-pvr-manager branch December 7, 2017 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants