Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] fix test suite after 40b368c8ec #13172

Merged
merged 1 commit into from
Dec 11, 2017
Merged

[windows] fix test suite after 40b368c8ec #13172

merged 1 commit into from
Dec 11, 2017

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Dec 11, 2017

How Has This Been Tested?

On Windows 10 Fall Creators Update

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@MartijnKaijser @notspiff FYI

@Rechi Rechi added Type: Fix non-breaking change which fixes an issue Tests v18 Leia Platform: Windows labels Dec 11, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Dec 11, 2017
@Rechi Rechi requested a review from afedchin December 11, 2017 19:58
@Rechi
Copy link
Member Author

Rechi commented Dec 11, 2017

Floating point exception in the test suite for linux is unrelated.

@Rechi Rechi merged commit d790c26 into xbmc:master Dec 11, 2017
@Rechi Rechi deleted the fixWindowsTestSuite branch December 11, 2017 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afedchin afedchin afedchin approved these changes

Assignees
No one assigned
Labels
Platform: Windows Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rechi @afedchin