Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AESinkFactory: Adjust Sndio #13183

Merged
merged 1 commit into from Dec 13, 2017
Merged

AESinkFactory: Adjust Sndio #13183

merged 1 commit into from Dec 13, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2017

Description

Adjust Sndio backend as requested by @fritsch in #13119.

If you need someone to adjust OSS as well, please let me know.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi
Copy link
Member

Rechi commented Dec 13, 2017

Not tested myself, but I think you need something like #13181 too, as not all files include system.h (where HAS_SNDIO is defined).

@Rechi Rechi added Component: Audio Type: Fix non-breaking change which fixes an issue Platform: Linux v18 Leia labels Dec 13, 2017
@@ -21,6 +21,7 @@
#include "system.h"
#ifdef HAS_SNDIO
#include "AESinkSNDIO.h"
#include "cores/AudioEngine/Engines/ActiveAE/ActiveAE.h"

This comment was marked as spam.

This comment was marked as spam.

Signed-off-by: Tobias Kortkamp <git@tobik.me>
@Rechi
Copy link
Member

Rechi commented Dec 13, 2017

jenkins build this please

else
{
if (!X11::PulseAudioRegister())
{
X11::ALSARegister();
if (!X11::ALSARegister())

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@fritsch
Copy link
Member

fritsch commented Dec 13, 2017

Jenkins is fine (minus the float issue). I will push that as my PulseRework needs rebasing ontop of this.

Thanks very much @t6 for reacing that fast.

@fritsch fritsch merged commit 5853600 into xbmc:master Dec 13, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Dec 13, 2017
@ghost ghost mentioned this pull request Apr 20, 2018
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants