windowing/gbm: fixes for startup and shutdown #13231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrusak
added
Type: Fix
|
Looks good to me code wise. |
peak3d
reviewed
Dec 22, 2017
xbmc/windowing/gbm/DRMUtils.cpp
Outdated
| delete m_connector; | ||
| m_connector = nullptr; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@peak3d fixed. thanks |
lrusak
commented
Dec 23, 2017
| drmModePlane *plane; | ||
| drmModeObjectProperties *props; | ||
| drmModePropertyRes **props_info; | ||
| drmModePlane *plane = nullptr; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special thanks to @peak3d for looking into some of these issues.
Please have a look over. I don't get any segfaults now at startup or shutdown.
@Kwiboo please check this also
@a1rwulf I think you had problems here also