Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup][TexturePacker] remove PlatformDefs include #13239

Merged
merged 1 commit into from
Dec 23, 2017
Merged

[cleanup][TexturePacker] remove PlatformDefs include #13239

merged 1 commit into from
Dec 23, 2017

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Dec 23, 2017

Description

  • remove unused function definitions
  • use char directly instead of a typedefs to char

Motivation and Context

makes cleaning up PlatformDefs.h easier as it isn't used by depends anymore

How Has This Been Tested?

  • compiled TexturePacker via depends on linux and osx
  • compiled TexturePacker via cmake on linux

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi
[cleanup][TexturePacker] remove PlatformDefs include
ccf5f5b 
- remove unused function definitions
- use char directly instead of a typedefs to char
@Rechi Rechi added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia labels Dec 23, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Dec 23, 2017
@Rechi Rechi requested a review from wsnipex December 23, 2017 09:30
wsnipex
wsnipex approved these changes Dec 23, 2017
View reviewed changes
Copy link
Member

@wsnipex wsnipex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Rechi Rechi merged commit e13685a into xbmc:master Dec 23, 2017
@Rechi Rechi deleted the cleanupTexturePacker branch December 23, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsnipex wsnipex wsnipex approved these changes

Assignees
No one assigned
Labels
Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rechi @wsnipex