Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGL: boost shader performance for Lanczos3 optimized #13260

Merged
merged 10 commits into from
Dec 29, 2017

Conversation

FernetMenta
Copy link
Contributor

See title. Allows HQ scaling on a 4k display.

Some cleanup in shader area.

@fritsch
Copy link
Member

fritsch commented Dec 29, 2017

Something went wrong from the version yesterday:
image

Seems like the offsets are wrong (vertical stripes)

Performance wise: Really great. It basically uses half the sampler load and therefore needs also only half the throughput per second. Tested with gputop.

@fritsch
Copy link
Member

fritsch commented Dec 29, 2017

@lrusak if you find an GLES < 3.1 alternative for textureGatherOffset you could adapt 1:1 - from my pov this is the source of most of the advancement we get here.

@fritsch
Copy link
Member

fritsch commented Dec 29, 2017

Update: Dithering is broken - the shader works fine :-)

Here is a summary of the work fernetmenta did and was pleased to help testing:
lanczos-vergleich

@fritsch
Copy link
Member

fritsch commented Dec 29, 2017

Load with new Shaderwork (Upscaling 576i50 to 3840 50p):
image

No skips, no drops.

@fritsch
Copy link
Member

fritsch commented Dec 29, 2017

Old implementation:
image

Server drops and skips. You can see the Sampler Load and the Texels needed is double of the new implementation and therefore unusable on slower systems. This could be the revival of the Baytrail :-) or the the intel HD2000 when OpenGL 4 drivers are available.

Test-Setup: Apollo Lake Broxton.

@fritsch
Copy link
Member

fritsch commented Dec 29, 2017

The squash commit fixes dithering - thx much.

@FernetMenta
Copy link
Contributor Author

jenkins build this please

@FernetMenta
Copy link
Contributor Author

UWP-64 error unrelated

@FernetMenta FernetMenta merged commit f3271af into xbmc:master Dec 29, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Dec 29, 2017
@axbmcuser axbmcuser mentioned this pull request Aug 22, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants