Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ftp with implicit SSL support #13285

Merged
merged 1 commit into from
Jan 2, 2018
Merged

add ftp with implicit SSL support #13285

merged 1 commit into from
Jan 2, 2018

Conversation

clementperon
Copy link
Contributor

Add support for FTP with implicit SSL

Description

Add a FTP server with implicit SSL using FTP server GUI doesn't work.
The protocol must be ftps:// and not ftp://

Motivation and Context

How Has This Been Tested?

Tested on Ubuntu 17.10 and personal ftp server

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi
Copy link
Member

Rechi commented Jan 1, 2018

jenkins build this please

@Rechi Rechi added Type: Improvement non-breaking change which improves existing functionality v18 Leia labels Jan 1, 2018
@Rechi Rechi requested a review from notspiff January 1, 2018 19:36
notspiff
notspiff approved these changes Jan 2, 2018
View reviewed changes
Copy link
Contributor

@notspiff notspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Rechi Rechi added this to the L 18.0-alpha1 milestone Jan 2, 2018
@Rechi Rechi merged commit d37a584 into xbmc:master Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notspiff notspiff notspiff approved these changes

Assignees
No one assigned
Labels
Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clementperon @Rechi @notspiff