changed: added setting for use of video tags #13291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
reviewed
Jan 2, 2018
|
|
||
| #: system/settings.xml | ||
| msgctxt "#21344" | ||
| msgid "If mp4 or mkv files have tags, use this to for library metadata" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ksooo
reviewed
Jan 2, 2018
| @@ -38,7 +40,8 @@ IVideoInfoTagLoader* CVideoInfoTagLoaderFactory::CreateLoader(const CFileItem& i | |||
| return nfo; | |||
| delete nfo; | |||
|
|
|||
| if (item.IsType(".mkv") || item.IsType(".mp4")) | |||
| if (CServiceBroker::GetSettings().GetBool("myvideos.usetags") && | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@MartijnKaijser approved? Not that fast, please... ;-) |
default to false
notspiff
force-pushed
the
video_tag_settings
branch
from
b037c6b
to
acc1424
Compare
ksooo
approved these changes
Jan 2, 2018
MartijnKaijser
added
Type: Feature
|
That was quick ;) |
|
Martijn excels at whining... ;)
3. jan. 2018 21:34 skrev "Memphiz" <notifications@github.com>:
… That was quick ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13291 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFktYLLmrkTycsP_mJzhm7dg-M4rtwmqks5tG-RVgaJpZM4RQu47>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to false.
Too much garbage in the tags in files out there..