Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed: added setting for use of video tags #13291

Merged
merged 1 commit into from Jan 2, 2018

Conversation

@notspiff
Copy link
Contributor

commented Jan 2, 2018

Default to false.

Too much garbage in the tags in files out there..

@MartijnKaijser
Copy link
Member

left a comment

Thanks :)


#: system/settings.xml
msgctxt "#21344"
msgid "If mp4 or mkv files have tags, use this to for library metadata"

This comment has been minimized.

Copy link
@ksooo

ksooo Jan 2, 2018

Member

to -> too ?

This comment has been minimized.

Copy link
@notspiff

notspiff Jan 2, 2018

Author Contributor

Ehrm 'to fill' or 'for' and i ended up with useless hybrid.

This comment has been minimized.

Copy link
@ksooo

ksooo Jan 2, 2018

Member

hehe

This comment has been minimized.

Copy link
@notspiff

notspiff Jan 2, 2018

Author Contributor

removed to 'to'

@@ -38,7 +40,8 @@ IVideoInfoTagLoader* CVideoInfoTagLoaderFactory::CreateLoader(const CFileItem& i
return nfo;
delete nfo;

if (item.IsType(".mkv") || item.IsType(".mp4"))
if (CServiceBroker::GetSettings().GetBool("myvideos.usetags") &&

This comment has been minimized.

This comment has been minimized.

Copy link
@notspiff

notspiff Jan 2, 2018

Author Contributor

I guess i will have to comply with this horrid idea ;)

This comment has been minimized.

Copy link
@notspiff

notspiff Jan 2, 2018

Author Contributor

added.

@ksooo

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

@MartijnKaijser approved? Not that fast, please... ;-)

@ksooo
Copy link
Member

left a comment

;-)

@notspiff notspiff force-pushed the notspiff:video_tag_settings branch from b037c6b to acc1424 Jan 2, 2018

@ksooo
ksooo approved these changes Jan 2, 2018

@MartijnKaijser MartijnKaijser merged commit a4ad91e into xbmc:master Jan 2, 2018

1 check failed

default Sorry, building this PR failed. Please check the logs for the errors.
Details

@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Jan 2, 2018

@notspiff notspiff deleted the notspiff:video_tag_settings branch Jan 2, 2018

@Memphiz

This comment has been minimized.

Copy link
Member

commented Jan 3, 2018

That was quick ;)

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.