[gui][fix] need splash window in history to render it properly

[xhaggi]

This will revert the WINDOW_SPLASH condition in CGUIWindowManager::AddToWindowHistory introduced by 9f6eb4d because we need the splash in history to render it properly. Without GetActiveWindow never return CGUIWindowSplash and therefore it's not rendered. We remove the splash window right after the GUI is ready https://github.com/xbmc/xbmc/blob/master/xbmc/Application.cpp#L3928

@ksooo FYI

[ksooo]

SImply reverting this imo is not okay, as it introduces an error log entry. See may comment here: #10280 (comment)

[xhaggi]

Added a separate commit which removes the window from history while it gets removed. I need to change the type which is used for the history because a std::stack can't be used to erase an item in the stack. The default container type is std::deque so I used that.

[xhaggi]

Alternatively, we can simply change the LOGERROR to LOGWARN

[ksooo]

Alternatively, we can simply change the LOGERROR to LOGWARN

-1 ;-)

[ksooo]

Question: Where do we land now if one sets a PVR window as startup window and closes this window? Do we go to the home window (without a warning)?

[xhaggi]

Question: Where do we land now if one sets a PVR window as startup window and closes this window? Do we go to the home window (without a warning)?

Yep .. there is a check if the window history size is lower 2 (that's the case for all startup windows) and if so it will go to WINDOW_HOME. https://github.com/xbmc/xbmc/blob/master/xbmc/guilib/GUIWindowManager.cpp#L691

[da-anda]

would it make sense to rename the "splash window" to something else, as it's clearly not used for the splash itself? Maybe make it even skinnable, as the splash image doesn't make too much sense f.e. the master lock screen. Just a thought.

[xhaggi]

IMO I would say no, leave as it is. I don't want to waste more time.

[ksooo]

:-)

[ksooo]

lgtm, thx