Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui] use select dialog instead of context menu for profile lock mode selection #13315

Merged
merged 2 commits into from
Jan 8, 2018
Merged

[gui] use select dialog instead of context menu for profile lock mode selection #13315

merged 2 commits into from
Jan 8, 2018

Conversation

xhaggi
Copy link
Member

@xhaggi xhaggi commented Jan 5, 2018

Some pros:

  • we use the select dialog for all multi value settings
  • pre-select the selected lock mode
  • set custom heading

screenshot001

@ronie any objections?

@xhaggi xhaggi added Component: GUI engine Type: Improvement non-breaking change which improves existing functionality labels Jan 5, 2018
@xhaggi xhaggi requested a review from ronie January 5, 2018 16:49
@xhaggi
Copy link
Member Author

xhaggi commented Jan 5, 2018

The second commit replaces the spinner used for profiles lock settings option with select dialog as well.

screenshot002

ronie
ronie reviewed Jan 8, 2018
View reviewed changes
Copy link
Member

@ronie ronie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, it's a bit odd we use the context menu here, when all other settings utilize the select dialog.

getting rid of another spinner is a bonus too.

@xhaggi xhaggi merged commit cf0ff1f into xbmc:master Jan 8, 2018
@notspiff
Copy link
Contributor

notspiff commented Jan 8, 2018

everything used the ctx menu before so your 'weird' is in the wrong order ;)

@Rechi Rechi added the v18 Leia label Jan 8, 2018
@Rechi Rechi added this to the L 18.0-alpha1 milestone Jan 8, 2018
@xhaggi xhaggi deleted the use-select-dialog-for-profile-lock-mode branch February 4, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronie ronie ronie left review comments

Assignees
No one assigned
Labels
Component: GUI engine Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xhaggi @notspiff @ronie @Rechi