[fix] register settings callback for weather manager is called before it is ready #13326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhaggi
force-pushed
the
fix-register-settings
branch
2 times, most recently
from
b63f693
to
9a3c15c
Compare
FernetMenta
reviewed
Jan 7, 2018
xbmc/ServiceManager.cpp
Outdated
| @@ -151,6 +152,9 @@ bool CServiceManager::InitStageTwo(const CAppParamParser ¶ms) | |||
|
|
|||
| m_weatherManager.reset(new CWeatherManager()); | |||
|
|
|||
| // register settings callbacks | |||
| GetSettings().GetSettingsManager()->RegisterCallback(m_weatherManager.get(), { CSettings::SETTING_WEATHER_ADDON, CSettings::SETTING_WEATHER_ADDONSETTINGS }); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
xhaggi
force-pushed
the
fix-register-settings
branch
from
9a3c15c
to
a19bc8e
Compare
xhaggi
force-pushed
the
fix-register-settings
branch
from
a19bc8e
to
48f90cc
Compare
|
had to kill all 5 triggers for this single PR. |
|
Thanks |
|
@xhaggi: There is another reference to the weather manager left in Settings.cpp : 48f90cc#diff-8d943449895d0ff6b503e49c8ecf6868R832 Is this intended? If not, the include for the weather manager header could be removed from Settings.cpp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @FernetMenta pointed out, the weather manager is not ready when we want to register the settings callbacks. Now the registration/deregistration is moved to our service manager.
@MartijnKaijser ping you too.