Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depends] bump python27 to 2.7.14 #13328

Merged
merged 4 commits into from Jan 11, 2018
Merged

[depends] bump python27 to 2.7.14 #13328

merged 4 commits into from Jan 11, 2018

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Jan 7, 2018

Description

  • use expat version from depends instead of bundled version from python
  • bump python to version 2.7.14
  • some cosmetics

Motivation and Context

Bundled expat was bumped and now doesn't compile anymore on osx (not tested other platforms). I didn't want to fix that so just switched to use version from our depends.

How Has This Been Tested?

compiled depends for osx, ios, appletvos and android
runtime tested (including elementtree module) on osx

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added this to the L 18.0-alpha1 milestone Jan 7, 2018
@Rechi Rechi requested a review from wsnipex January 7, 2018 17:16
@Rechi
Copy link
Member Author

Rechi commented Jan 11, 2018

@wsnipex ping

Copy link
Member

@wsnipex wsnipex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rechi Rechi merged commit 794bfa5 into xbmc:master Jan 11, 2018
@Rechi Rechi deleted the bumpPython branch January 11, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants