[PVR] Fix crashes on pvr client addon install/uninstall/update. #13335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
Jalle19
approved these changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was changing pvr client addon install/uninstall/enable/disable from reacting on synchronous methods to addon events I overlooked some important pieces, which led to all kind of weird behavior. For instance on install, both the addon event
Enabledwill be fired and a synchronousOnPostInstallwill be called, and PVR reacted on both.This was leading to an attempt to create the same addon instance twice, which often ended in a crash. This PR fixes this by eliminating the
CPVRClient::OnPostInstallandCPVRClient::OnPostUninstallimplementations and now uses events whenever possible.The changes are runtime tested on macOS and Linux, latest Kodi master plus pvr.hts and other pvr client addons in several scenarios.
@Jalle19 do you want to take a look at the code changes?