Update RetroPlayer's Render Manager documentation #13341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garbear btw: you know that RP's rendering path is very very very inefficient? iirc you took the code from picture renderer which works without things like PBO (or equivalent on Win) and as a result it syncs CPU and CPU on every frame. For video this is no-go. |
|
The windows code came from VP, and the picture renderer was so bad that I dropped it and just used a GUI texture for now. It'd be nice to have a dedicated GL/ES renderer but I'm busy finishing input for v18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some documentation to RPRenderManager.
Motivation and Context
I wrote this back in November of last year, but was waiting for a RetroPlayer PR to include this in to reduce GitHub noise. Apparently there's been no RetroPlayer issues that warranted a PR, so I might as well get this in now.