Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RetroPlayer's Render Manager documentation #13341

Merged
merged 2 commits into from Jan 11, 2018

Conversation

@garbear
Copy link
Member

commented Jan 10, 2018

This adds some documentation to RPRenderManager.

Motivation and Context

I wrote this back in November of last year, but was waiting for a RetroPlayer PR to include this in to reduce GitHub noise. Apparently there's been no RetroPlayer issues that warranted a PR, so I might as well get this in now.

@garbear garbear added this to the L 18.0-alpha1 milestone Jan 10, 2018
@FernetMenta

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

@garbear btw: you know that RP's rendering path is very very very inefficient? iirc you took the code from picture renderer which works without things like PBO (or equivalent on Win) and as a result it syncs CPU and CPU on every frame. For video this is no-go.

@garbear

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2018

The windows code came from VP, and the picture renderer was so bad that I dropped it and just used a GUI texture for now. It'd be nice to have a dedicated GL/ES renderer but I'm busy finishing input for v18.

@garbear garbear merged commit 2fba47d into xbmc:master Jan 11, 2018
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@garbear garbear deleted the garbear:retroplayer-doxy branch Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.