[fix] boolean condition window.is does not work properly #13346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boolean condition Window.Is does not work properly because the contextual window is not always set. This will try to fix the issue by introducing a fallback. Now we'll first lookup for the contextual window, than the top most dialog and as a last the top most window.
xhaggi
added
Type: Fix
|
@ronie it would be nice if you take a look and verify if it works for Estuary. |
|
tested and works fine as far as i can tell |
|
Ok thanks for your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boolean condition Window.Is does not work properly because the contextual window is not always set. This will try to fix the issue by introducing a fallback. Now we'll first lookup for the contextual window, than the top most dialog and as a last the top most window.
The same is done in
CGUIInfoManager::GetWindowWithCondition(int contextWindow, int condition)where pass in the contextual window too.Runtime tested on MacOS.
Related forum thread https://forum.kodi.tv/showthread.php?tid=307923