Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] refactor window is topmost methods and add new boolean conditions #13348

Merged
merged 7 commits into from Jan 12, 2018

Conversation

@xhaggi
Copy link
Member

commented Jan 11, 2018

Most of the stuff is cleanup/refactoring and explained in the commit message.

There are now two new info bools for skinners. The first replaces Window.IsTopMost with Window.IsDialogTopmost and the other Window.IsModalDialogTopmost is used to check if the given dialog is the topmost modal dialog.

@phil65 @ronie mind taking a look.

@xhaggi xhaggi force-pushed the xhaggi:refactor-window-is-top-most branch from 985ba22 to 5b89bf2 Jan 11, 2018
@xhaggi

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2018

Jenkins build this please

@xhaggi xhaggi requested a review from Paxxi Jan 11, 2018
@xhaggi xhaggi changed the title [gui] refactor window is top most methods and add new boolean conditions [gui] refactor window is topmost methods and add new boolean conditions Jan 11, 2018
@phil65

This comment has been minimized.

Copy link
Member

commented Jan 11, 2018

looks good.

@xhaggi xhaggi merged commit cb57886 into xbmc:master Jan 12, 2018
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@Rechi Rechi added this to the L 18.0-alpha1 milestone Jan 13, 2018
@xhaggi xhaggi deleted the xhaggi:refactor-window-is-top-most branch Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.