Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: show the actual set poster/fanart for sets #13371

Closed
wants to merge 1 commit into from

Conversation

notspiff
Copy link
Contributor

only show relevant art types in the Choose art dialog. @olympia

@olympia
Copy link

olympia commented Jan 15, 2018

Great spiff, many thanks! (is there no good snow or what? :) )

(you remember I am unable to test now, right?)

@notspiff
Copy link
Contributor Author

can't you just get the jenkins build artifact ?

@olympia
Copy link

olympia commented Jan 15, 2018

I will surely disappoint you by saying I have no idea what that is, but that's reality...

@notspiff
Copy link
Contributor Author

it would be a windows installer however it seems we do not produce those as artifacts for the auto builds.

@notspiff
Copy link
Contributor Author

@Rechi
Copy link
Member

Rechi commented Jun 10, 2018

@notspiff anything missing?

@olympia
Copy link

olympia commented Jun 13, 2018

Yes, there is still some feature to add, before this could be merged. Would be extremely nice to have this for v18. @notspiff, would you have the mood and time to code this around?

only show relevant art types in the Choose art dialog
@MartijnKaijser
Copy link
Member

@notspiff was this ready or not?

@notspiff notspiff closed this Oct 16, 2018
@notspiff
Copy link
Contributor Author

No and @rmrector is on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants