windowing: amlogic: set framebuffer to maximum size before initializing EGL #13391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng EGL If framebuffer size is less than 1920x1080 (for example 1280x720) before initialization of EGL, an attempt to set resolution in Kodi to 1080p or higher will result in EGL_BAD_ALLOC error during a call to eglCreateContext(). This commit fixes the issue by setting framebuffer to maximum possible size before initializing EGL.
peak3d
approved these changes
Jan 21, 2018
Rechi
added
Type: Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set framebuffer to maximum size before initializing EGL on Amlogic-based devices.
Description
If framebuffer size is less than 1920x1080 (for example 1280x720) before
initialization of EGL, an attempt to set resolution in Kodi to 1080p or
higher will result in EGL_BAD_ALLOC error during a call to eglCreateContext().
This PR fixes the issue by setting framebuffer to maximum possible size
before initializing EGL.
Motivation and Context
Fixes Kodi crash if display resolution is set to 1080p or higher in settings, but set to less than 1080p by system before Kodi starts.
How Has This Been Tested?
Tested on WeTek Play 2 (Amlogic S905) with LibreELEC by setting default resolution to 720p in uboot.
Screenshots (if appropriate):
Types of change
Checklist: