Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLES] VideoShader cleanup #13416

Merged
merged 5 commits into from Jan 28, 2018

Conversation

@lrusak
Copy link
Contributor

commented Jan 23, 2018

This cleans up and removes unused code for the GLES rendering path.

Currently stretch, 3dlut, and limited color range aren't used by GLES, let's clean it up for now.

Commit's are just broke up logically to allow for easier review.

build and run tested on linux using GBM

@lrusak lrusak added the v18 Leia label Jan 23, 2018
@lrusak lrusak requested a review from FernetMenta Jan 23, 2018
@FernetMenta

This comment has been minimized.

Copy link
Member

commented Jan 23, 2018

looking at the code it seems fine. we should runtime test this on the verious gles platforms

@lrusak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2018

@lrusak lrusak force-pushed the lrusak:gles-cleanup branch from 82b297c to e88ad3e Jan 24, 2018
@lrusak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2018

Can I get various platform maintainers to test this? @popcornmix @peak3d
@MilhouseVH for inclusion in an RPi build (disabling hw accelleration will allow this code path)

@lrusak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2018

I'm going to say that this is good to go 😸

lrusak added 5 commits Jan 23, 2018
@lrusak lrusak force-pushed the lrusak:gles-cleanup branch from e88ad3e to fd1efb8 Jan 27, 2018
@lrusak lrusak merged commit e1e969b into xbmc:master Jan 28, 2018
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@Rechi Rechi added the Type: Cleanup label Jan 28, 2018
@Rechi Rechi added this to the L 18.0-alpha1 milestone Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.