Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLES] VideoShader cleanup #13416

Merged
merged 5 commits into from
Jan 28, 2018
Merged

[GLES] VideoShader cleanup #13416

merged 5 commits into from
Jan 28, 2018

Conversation

lrusak
Copy link
Contributor

@lrusak lrusak commented Jan 23, 2018

This cleans up and removes unused code for the GLES rendering path.

Currently stretch, 3dlut, and limited color range aren't used by GLES, let's clean it up for now.

Commit's are just broke up logically to allow for easier review.

build and run tested on linux using GBM

@FernetMenta
Copy link
Contributor

looking at the code it seems fine. we should runtime test this on the verious gles platforms

@lrusak
Copy link
Contributor Author

lrusak commented Jan 23, 2018

tested on android also and it seems ok http://mirrors.kodi.tv/test-builds/android/arm/kodi-20180122-82b297c5-gles-cleanup-armeabi-v7a.apk

@jenkins4kodi jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Jan 24, 2018
@jenkins4kodi jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label Jan 24, 2018
@lrusak
Copy link
Contributor Author

lrusak commented Jan 25, 2018

Can I get various platform maintainers to test this? @popcornmix @peak3d
@MilhouseVH for inclusion in an RPi build (disabling hw accelleration will allow this code path)

@lrusak
Copy link
Contributor Author

lrusak commented Jan 26, 2018

I'm going to say that this is good to go 😸

@jenkins4kodi jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Jan 27, 2018
@jenkins4kodi jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label Jan 27, 2018
@lrusak lrusak merged commit e1e969b into xbmc:master Jan 28, 2018
@Rechi Rechi added the Type: Cleanup non-breaking change which removes non-working or unmaintained functionality label Jan 28, 2018
@Rechi Rechi added this to the L 18.0-alpha1 milestone Jan 28, 2018
@MilhouseVH
Copy link
Contributor

Problems being reported by RPi users with LiveTV playback since this was included:

https://forum.kodi.tv/showthread.php?tid=298461&pid=2697224#pid2697224
https://forum.kodi.tv/showthread.php?tid=298461&pid=2697525#pid2697525
https://forum.kodi.tv/showthread.php?tid=298461&pid=2697568#pid2697568
https://forum.kodi.tv/showthread.php?tid=298461&pid=2697591#pid2697591

@jjd-uk jjd-uk mentioned this pull request Aug 10, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernetMenta FernetMenta FernetMenta approved these changes

Assignees
No one assigned
Labels
Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lrusak @FernetMenta @MilhouseVH @Rechi @jenkins4kodi