[fix] move virtual window handling to translators to solve issue with remote mappings

[xhaggi]

@MilhouseVH hope this will fix the reported issue #13433 (comment)

Runtime tested with keyboard mappings for virtual windows and works fine.
I can't test remote mappings because I don't have a remote control anymore (using FLIRC).

[garbear]

Gotta run but I can review this tmrw. I noticed, when looking at these lines:

window = CWindowTranslator::GetVirtualWindow(window);

this would be easier to reason about if all virtual window IDs had "virtual" in the variable name, e.g.

int virtualWindow = CWindowTranslator::GetVirtualWindow(window);

similar to how we include units in the variable name.

Then we could verify that:

• All keymap lookups are by virtual window ID
• Actual -> virtual translation isn't done twice (although here this isn't an issue as GetVirtualWindow() is idempotent)

[xhaggi]

Sure can adjust the variables.

[xhaggi]

@garbear I thought about it again and it doesn't make much sense to change the variable, because it's not necessarily a virtual window ID.

[MilhouseVH]

@xhaggi many thanks, I've posted a test build on the forum - I'll let you know the feedback.

[MilhouseVH]

@HiassofT gave the new test build with this PR a quick test and says it's looking good but will test more tomorrow (Saturday). Hopefully forum users are also able to confirm similar results.

[xhaggi]

@MilhouseVH thanks for the fast response and test build.

[xhaggi]

Forum users reported it's fixed now.

[HiassofT]

With this commit OK button is correctly mapped to OSD action again (previously it was Select) during livetv:

10:17:24.003 T:1941955584   DEBUG: LIRC: Update - NEW at 49526:160 0 KEY_OK devinput (KEY_OK)
10:17:24.003 T:1941955584   DEBUG: HandleKey: 11 (0x0b, obc244) pressed, action is OSD
10:17:24.004 T:1941955584   DEBUG: ------ Window Init (VideoOSD.xml) ------

Other remote buttons work fine during livetv as well.

Thanks a lot for the quick fix, it looks good to me!

[xhaggi]

@garbear any objections?