[GLES] more shader cleanup #13446
Merged
[GLES] more shader cleanup #13446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrusak
added
Type: Cleanup
|
Why is Copyright and licensing being removed from these files ? |
lrusak
force-pushed
the
gles-cleanup-next
branch
from
3993df0
to
eda50e3
Compare
|
@MrMC I'm not really sure. I think it had to do with running through the glslangValidator, but it seems to work fine with the headers. I've fixed it. |
|
thx, copyright and licensing should never get removed without the consent of the authors. |
|
Yep sorry, that's my bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a few purposes:
.fragand.vertextensionsgit does something funny when displaying the complete diff as it shows some files being removed and some new files being added. This is because the diff only detects the same file if it is 50% or more similar. So when removing the header which is over 50% of the file git thinks the file isn't the same. So I have split the commits into renaming the files, then in another commit changing the contents. If you view the individual commits it show things more clearly. This also allows the git history to be complete. If anyone has any hints or tips about this that would be awesome.
build and runtime tested on GBM but should be worth testing on android and other GLES platforms.