RetroPlayer: Input fixes #13531
Merged
RetroPlayer: Input fixes #13531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes pausing and resuming after the WindowManager cleanup in PR 13433.
In practice, while button-mashing, a player can hit Select+B and cause a reset, but without an easy way to undo this reset, gameplay progress can be lost.
garbear
added
Type: Fix
In practice, while intense button-mashing, a player can hit Select+A and cause a series of annoying, confusing dialogs.
|
Added a third fix disabling the screenshot hotkey. |
|
All green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains
twothree fixes:Description
Pause/play was broken because RP was checking active window (always itself) instead of active window or dialog (which ignored the Game OSD dialog).
During gameplay, when shit gets real and buttons get mashed, players can press Select+B causing an unexpected reset. Disable this hotkey until/if resets are easily undoable. Functionality is still available through the Game OSD.
Similarly, the screenshot hotkey is somewhat broken and opens up multiple annoying confusing dialogs. Disable this until it has been further automated.
How Has This Been Tested?
Tested on OSX.
Screenshots (if appropriate):
Game OSD without the reset hotkey:
Types of change