Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: [3D] broken since awhile #13535

Merged
merged 2 commits into from
Feb 14, 2018
Merged

FIX: [3D] broken since awhile #13535

merged 2 commits into from
Feb 14, 2018

Conversation

koying
Copy link
Contributor

@koying koying commented Feb 12, 2018

Follow-up to #13395
Thanks to @afl1 for the initial work

@koying koying added Type: Fix non-breaking change which fixes an issue Component: GUI rendering v18 Leia labels Feb 12, 2018
FernetMenta
FernetMenta approved these changes Feb 12, 2018
View reviewed changes
Copy link
Contributor

@FernetMenta FernetMenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok I think. Only have a smart phone here atm

da-anda
da-anda reviewed Feb 12, 2018
View reviewed changes
Copy link
Member

@da-anda da-anda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on first glance. Will trigger a test build.

da-anda
da-anda reviewed Feb 12, 2018
View reviewed changes
xbmc/guilib/StereoscopicsManager.cpp
@@ -46,6 +46,7 @@
#include "utils/Variant.h"
#include "rendering/RenderSystem.h"
#include "guiinfo/GUIInfoLabels.h"
#include "cores/DataCacheCore.h"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@da-anda
Copy link
Member

da-anda commented Feb 12, 2018

@koying from my testing, the triggering of the 3D behavior is working fine again. But i noticed that movies with missing meta-data (detected by filename flags) don't have the "3D goggles" icon in the video OSD menu. I suppose some stream flag is not updated?

@garbear thanks for the headsup

@popcornmix
Copy link
Member

Looks good on a quick test on Pi.

@koying
Copy link
Contributor Author

koying commented Feb 13, 2018

@da-anda Not sure what you mean.
If the movie lacks the 3D metadata, ofc you won't get the "3d goggles".
Probably a scanner issue, though. Please slack me the filename and I'll have a look.

jenkins build this please

@da-anda da-anda merged commit 54b1d5a into xbmc:master Feb 14, 2018
@Rechi Rechi added this to the L 18.0-alpha1 milestone Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbear garbear garbear left review comments

@FernetMenta FernetMenta FernetMenta approved these changes

@da-anda da-anda da-anda approved these changes

Assignees
No one assigned
Labels
Component: GUI rendering Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@koying @da-anda @popcornmix @garbear @FernetMenta @Rechi