RetroPlayer: Improve logging #13540
Merged
RetroPlayer: Improve logging #13540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks dude looks great! merge away! |
lrusak
reviewed
Feb 13, 2018
| CloseStream(); | ||
| m_renderManager.Deinitialize(); | ||
| } | ||
|
|
||
| bool CRetroPlayerVideo::OpenPixelStream(AVPixelFormat pixfmt, unsigned int width, unsigned int height, unsigned int orientationDeg) | ||
| { | ||
| CLog::Log(LOGINFO, "RetroPlayerVideo: Creating video stream with pixel format: %i, %dx%d", pixfmt, width, height); | ||
| CLog::Log(LOGDEBUG, "RetroPlayer[VIDEO]: Creating video stream %ux%u", width, height); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -76,7 +77,15 @@ bool CRPBaseRenderer::Configure(AVPixelFormat format, unsigned int width, unsign | |||
| m_renderOrientation = orientation; | |||
|
|
|||
| if (!m_bufferPool->IsConfigured()) | |||
| m_bufferPool->Configure(format, width, height); | |||
| { | |||
| CLog::Log(LOGDEBUG, "RetorPlayer[RENDER]: Configuring buffer pool"); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| if (!m_bufferPool->Configure(format, width, height)) | ||
| { | ||
| CLog::Log(LOGERROR, "RetorPlayer[RENDER]: Failed to configure buffer pool"); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Beefed up logging a little more. jenkins build this please |
|
jenkins build this please |
|
linux64 error in test suite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The renderer was written kinda hastily, and I've been told that logging important information is lacking. This PR augments logging and clarifies which subsystem the log line originates from.
How Has This Been Tested?
RetroPlayer now produces the following log lines for normal gameplay (and from inspection, I've determined that most errors emit their error line):
It kinda highlights that some things aren't strictly ordered. I may reorder some stuff before merging.
@lrusak would you like to see any additional information?
Types of change