[pvr] add PVR and EPG support to XBMC #1357

Merged
merged 2 commits into from Sep 4, 2012

Conversation

Projects
None yet
@opdenkamp
Member

opdenkamp commented Sep 2, 2012

add-ons are not included, but can be found here: https://github.com/opdenkamp/xbmc-pvr-addons

when the pvr manager is enabled without any pvr add-ons installed, then the following warning text will be displayed: "No PVR add-ons could be found. You need a tuner, backend software, and an add-on for the backend to be able to use PVR. Please visit xbmc.org/PVR to learn more."
this page needs to be created (just forward to the wiki page about pvr and update that one?)

when the pvrmanager is enabled, and there are add-ons found, but none is enabled, then the user will see a warning message that he needs to enable at least one add-on, and is taken to the add-ons directory with the disabled add-ons.

pvr related issues that i assigned to the frodo milestone (that i'd like to fix or see fixed before frodo final) can be found here: https://github.com/opdenkamp/xbmc/issues?milestone=3&state=open
i haven't checked and cleaned up trac tickets lately.

@Memphiz

This comment has been minimized.

Show comment Hide comment
@Memphiz

Memphiz Sep 2, 2012

Member

Great work Lars - will fixup the Xcode projects for iOS and atv2 tomorrow in the train :D

Member

Memphiz commented Sep 2, 2012

Great work Lars - will fixup the Xcode projects for iOS and atv2 tomorrow in the train :D

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 2, 2012

Member

cheers! you got r/w access to the repos now

Member

opdenkamp commented Sep 2, 2012

cheers! you got r/w access to the repos now

@sofakng

This comment has been minimized.

Show comment Hide comment
@sofakng

sofakng Sep 3, 2012

Very exited about this!

sofakng commented Sep 3, 2012

Very exited about this!

@garbear

This comment has been minimized.

Show comment Hide comment
@garbear

garbear Sep 3, 2012

Member

It looks like we have unused variables at here and here

Would it be possible to split up the big commit so that lib/ additions and xbmc/pvr/ additions are in separate commits? I know it breaks compilation but it's too big for github to load the commit diff

edit, nevermind just realized I can do it myself

Member

garbear commented Sep 3, 2012

It looks like we have unused variables at here and here

Would it be possible to split up the big commit so that lib/ additions and xbmc/pvr/ additions are in separate commits? I know it breaks compilation but it's too big for github to load the commit diff

edit, nevermind just realized I can do it myself

@ghost

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Sep 3, 2012

there are d in the big commit. it needs explaion. just a gut reaction with just a phone

ghost commented Sep 3, 2012

there are d in the big commit. it needs explaion. just a gut reaction with just a phone

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

@cptspiff "there are d in the big commit. it needs explaion. just a gut reaction with just a phone"
sorry, "d"? i'll be happy to add more explanation, just not sure what you'd like to see explained :)

Member

opdenkamp commented Sep 3, 2012

@cptspiff "there are d in the big commit. it needs explaion. just a gut reaction with just a phone"
sorry, "d"? i'll be happy to add more explanation, just not sure what you'd like to see explained :)

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

@garbear those left overs from earlier. have been removed again in a later commit. i'll push a squashed commit

Member

opdenkamp commented Sep 3, 2012

@garbear those left overs from earlier. have been removed again in a later commit. i'll push a squashed commit

system/PVRDemoAddonSettings.xml
+ </entry>
+
+ </epg>
+</demo>

This comment has been minimized.

Show comment Hide comment
@da-anda

da-anda Sep 3, 2012

Member

looks like this file is a leftover (as mentioned on IRC)

@da-anda

da-anda Sep 3, 2012

Member

looks like this file is a leftover (as mentioned on IRC)

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

it is indeed. this is now included in the add-on

@opdenkamp

opdenkamp Sep 3, 2012

Member

it is indeed. this is now included in the add-on

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

i've removed the file

@opdenkamp

opdenkamp Sep 3, 2012

Member

i've removed the file

+ m_epgInfoTag = NULL;
+ m_pvrChannelInfoTag = NULL;
+ m_pvrRecordingInfoTag = NULL;
+ m_pvrTimerInfoTag = NULL;
m_pictureInfoTag = NULL;

This comment has been minimized.

Show comment Hide comment
@da-anda

da-anda Sep 3, 2012

Member

not related to this PVR PR, just a general notice on FileItem.cpp: Can't all that m_xyzInfoTag = NULL; stuff that's repeated in this file like hundreds of times be moved to a private function or even the "reset()" function?

@da-anda

da-anda Sep 3, 2012

Member

not related to this PVR PR, just a general notice on FileItem.cpp: Can't all that m_xyzInfoTag = NULL; stuff that's repeated in this file like hundreds of times be moved to a private function or even the "reset()" function?

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

yeah this gets kind of messy when new types are added to CFileItem. but it's not related to this PR indeed, so we can pick that up later

@opdenkamp

opdenkamp Sep 3, 2012

Member

yeah this gets kind of messy when new types are added to CFileItem. but it's not related to this PR indeed, so we can pick that up later

@bennykill

This comment has been minimized.

Show comment Hide comment
@bennykill

bennykill Sep 3, 2012

I dont't think that the raspberry is powerfull enough to navigate through the channel list while watching a channel! Tried it with raspbmc R4 connected to a tvheadend server witch ran on an ubuntu pc and got crashes, picture bugs and so on! Main problem is the CPU performance! :(

I dont't think that the raspberry is powerfull enough to navigate through the channel list while watching a channel! Tried it with raspbmc R4 connected to a tvheadend server witch ran on an ubuntu pc and got crashes, picture bugs and so on! Main problem is the CPU performance! :(

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

@bennykill you need to wait until both pvr and rpi support are in mainline and i can't help you with quirks in someone's pvr+rpi merge attempt

Member

opdenkamp commented Sep 3, 2012

@bennykill you need to wait until both pvr and rpi support are in mainline and i can't help you with quirks in someone's pvr+rpi merge attempt

@Memphiz

This comment has been minimized.

Show comment Hide comment
@Memphiz

Memphiz Sep 3, 2012

Member

Beside that we are working here and this information was totally useless to us for this pull request.

@opdenkamp - with "D" spiff means the deleted files in that big commit.

Member

Memphiz commented Sep 3, 2012

Beside that we are working here and this information was totally useless to us for this pull request.

@opdenkamp - with "D" spiff means the deleted files in that big commit.

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

@Memphiz @cptspiff right thanks, i'll add an explanation for those

Member

opdenkamp commented Sep 3, 2012

@Memphiz @cptspiff right thanks, i'll add an explanation for those

@bennykill

This comment has been minimized.

Show comment Hide comment
@bennykill

bennykill Sep 3, 2012

@Memphiz With this information I wanted to help by telling you about my experiences. Because implementing PVR support isnt necessary when the hardware isnt strong enough! ;) Someone who wants to use XBMC as a receiver also wants to use a channel list! ;)

@Memphiz With this information I wanted to help by telling you about my experiences. Because implementing PVR support isnt necessary when the hardware isnt strong enough! ;) Someone who wants to use XBMC as a receiver also wants to use a channel list! ;)

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

@bennykill the information is useless for this PR, like memphiz already said. you need to wait. and every comment on this PR will send mails to 100+ people so please leave it at this for now, unless you have some valid comment about the code changes in this PR.

Member

opdenkamp commented Sep 3, 2012

@bennykill the information is useless for this PR, like memphiz already said. you need to wait. and every comment on this PR will send mails to 100+ people so please leave it at this for now, unless you have some valid comment about the code changes in this PR.

@wsoltys

This comment has been minimized.

Show comment Hide comment
@wsoltys

wsoltys Sep 3, 2012

Member

compiles and works fine on windows (tested with the vnsi plugin and my vdr). I don't have nav sounds with directsound but other audio is fine (mp3, live tv, etc). Maybe @DDDamian could have a look at it. Otherwise its fine and I'm okay with the merge.

Member

wsoltys commented Sep 3, 2012

compiles and works fine on windows (tested with the vnsi plugin and my vdr). I don't have nav sounds with directsound but other audio is fine (mp3, live tv, etc). Maybe @DDDamian could have a look at it. Otherwise its fine and I'm okay with the merge.

@wsoltys

This comment has been minimized.

Show comment Hide comment
@wsoltys

wsoltys Sep 3, 2012

Member

Another thing I noticed is that the description for settings->server is the same like settings->live tv. I use German but since its English I assume it uses the default values.

Member

wsoltys commented Sep 3, 2012

Another thing I noticed is that the description for settings->server is the same like settings->live tv. I use German but since its English I assume it uses the default values.

@DDDamian

This comment has been minimized.

Show comment Hide comment
@DDDamian

DDDamian Sep 3, 2012

Contributor

@wsoltys - no TV tuner card here (thx to opdenkamp & others I now have an incentive) so not much help in testing. For nav sounds enable <streamsilence under <audio heading in as.xml so engine doesn't sleep. Since adding suspend / resume I'm adding some other functionality to restore nav sounds without re-opening sink from suspend mode with every GUI beep ;)

Contributor

DDDamian commented Sep 3, 2012

@wsoltys - no TV tuner card here (thx to opdenkamp & others I now have an incentive) so not much help in testing. For nav sounds enable <streamsilence under <audio heading in as.xml so engine doesn't sleep. Since adding suspend / resume I'm adding some other functionality to restore nav sounds without re-opening sink from suspend mode with every GUI beep ;)

@wsoltys

This comment has been minimized.

Show comment Hide comment
@wsoltys

wsoltys Sep 3, 2012

Member

you don't need the hw for testing the navsounds for this branch :)

Member

wsoltys commented Sep 3, 2012

you don't need the hw for testing the navsounds for this branch :)

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

@wsoltys thanks, I'll check that out. probably my mistake when merging that in earlier when that category was added

@DDDamian there's a demo add-on now that you can use that simulates a pvr backend. just plays back an internet stream, so it's not the same as playing back from hts or vdr, but that shouldn't matter for navsounds

Member

opdenkamp commented Sep 3, 2012

@wsoltys thanks, I'll check that out. probably my mistake when merging that in earlier when that category was added

@DDDamian there's a demo add-on now that you can use that simulates a pvr backend. just plays back an internet stream, so it's not the same as playing back from hts or vdr, but that shouldn't matter for navsounds

@DDDamian

This comment has been minimized.

Show comment Hide comment
@DDDamian

DDDamian Sep 3, 2012

Contributor

Sorry tags lost to parser lol - tag is streamsilence under audio heading.

@opdenkamp - then test I shall! Congrats btw.

Contributor

DDDamian commented Sep 3, 2012

Sorry tags lost to parser lol - tag is streamsilence under audio heading.

@opdenkamp - then test I shall! Congrats btw.

@ghost ghost assigned opdenkamp Sep 3, 2012

@wsoltys

This comment has been minimized.

Show comment Hide comment
@wsoltys

wsoltys Sep 3, 2012

Member

The file win32/stdbool.h is added but I can't find where its used right now. Maybe a leftover?

Member

wsoltys commented Sep 3, 2012

The file win32/stdbool.h is added but I can't find where its used right now. Maybe a leftover?

@elupus

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Sep 3, 2012

Member

Stdbool.h us good to have broken systems like Windows :-). so leave it.

Member

elupus commented Sep 3, 2012

Stdbool.h us good to have broken systems like Windows :-). so leave it.

@Fneufneu

This comment has been minimized.

Show comment Hide comment
@Fneufneu

Fneufneu Sep 3, 2012

Member

build fine on FreeBSD

Member

Fneufneu commented Sep 3, 2012

build fine on FreeBSD

@dersphere

This comment has been minimized.

Show comment Hide comment
@dersphere

dersphere Sep 3, 2012

Member

Not sure if this is a surprise but builds (and works so far) fine on ubuntu 12.04 ;-)

Member

dersphere commented Sep 3, 2012

Not sure if this is a surprise but builds (and works so far) fine on ubuntu 12.04 ;-)

@wsoltys

This comment has been minimized.

Show comment Hide comment
@wsoltys

wsoltys Sep 3, 2012

Member

@DDDamian current master is also missing the nav sounds with direct sound so not related to pvr.

Member

wsoltys commented Sep 3, 2012

@DDDamian current master is also missing the nav sounds with direct sound so not related to pvr.

@Montellese

This comment has been minimized.

Show comment Hide comment
@Montellese

Montellese Sep 3, 2012

Member

Nice work on this. Congrats.
Would it be possible to take out the PVR-specific additions to JSON-RPC and do them in a seperate PR. I currently don't have the possibility to test them and I don't want to stall the whole PVR stuff from going in just because of things I'd like to do differently in the JSON-RPC API. But I also don't want to add a new set of methods and then change it again a week or two later.

If it's too much hassle to take it out and do a seperate PR afterwards I'll just fix it up later when I got time. AFAIK you didn't write that code yourself either so you won't be the right person to answer my questions on it.

Member

Montellese commented Sep 3, 2012

Nice work on this. Congrats.
Would it be possible to take out the PVR-specific additions to JSON-RPC and do them in a seperate PR. I currently don't have the possibility to test them and I don't want to stall the whole PVR stuff from going in just because of things I'd like to do differently in the JSON-RPC API. But I also don't want to add a new set of methods and then change it again a week or two later.

If it's too much hassle to take it out and do a seperate PR afterwards I'll just fix it up later when I got time. AFAIK you didn't write that code yourself either so you won't be the right person to answer my questions on it.

@RobertMe

This comment has been minimized.

Show comment Hide comment
@RobertMe

RobertMe Sep 3, 2012

Contributor

@Montellese
Unsure about what you would like to do on the JSON side of things (only adding/extending the PVR API, or internally changing how JSON-RPC works?) But I'm already doing some work on the JSON API for PVR (current code isn't mine). @opdenkamp already told me he wouldn't like to include my work right now (in this PR). But I'm continuing development on it and already did a few things differently (most PVR methods which are in this PR should be part of Player IMHO, for one). One of the changes I already did was adding Player integration (opdenkamp#626) and currently I'm working on "read" support, so things like PVR.GetChannels etc.

Contributor

RobertMe commented Sep 3, 2012

@Montellese
Unsure about what you would like to do on the JSON side of things (only adding/extending the PVR API, or internally changing how JSON-RPC works?) But I'm already doing some work on the JSON API for PVR (current code isn't mine). @opdenkamp already told me he wouldn't like to include my work right now (in this PR). But I'm continuing development on it and already did a few things differently (most PVR methods which are in this PR should be part of Player IMHO, for one). One of the changes I already did was adding Player integration (opdenkamp#626) and currently I'm working on "read" support, so things like PVR.GetChannels etc.

+}
+
+
+};

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Sep 3, 2012

Member

This stuff is clearly something that should be generated by @jimfcarroll code generation stuff at some point in the future.

@elupus

elupus Sep 3, 2012

Member

This stuff is clearly something that should be generated by @jimfcarroll code generation stuff at some point in the future.

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

yes, that would indeed be a lot nicer. tbh, i'm not sure whether any add-on is actually using this right now. haven't updated that recently, so things might be missing that are available in guilib. just fixed it up when it failed to compile by implementing the changes when merging it in. but i haven't used or tested any of the gui stuff in here.

@opdenkamp

opdenkamp Sep 3, 2012

Member

yes, that would indeed be a lot nicer. tbh, i'm not sure whether any add-on is actually using this right now. haven't updated that recently, so things might be missing that are available in guilib. just fixed it up when it failed to compile by implementing the changes when merging it in. but i haven't used or tested any of the gui stuff in here.

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

@Montellese @RobertMe shouldn't be too hard to undo the json-rpc changes. i'll have a look at it and will update this PR

Member

opdenkamp commented Sep 3, 2012

@Montellese @RobertMe shouldn't be too hard to undo the json-rpc changes. i'll have a look at it and will update this PR

xbmc/URL.cpp
@@ -183,6 +184,7 @@ void CURL::Parse(const CStdString& strURL1)
if(strProtocol2.Equals("http")
|| strProtocol2.Equals("https")
|| strProtocol2.Equals("plugin")
+ || m_strProtocol.Equals("addon")

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Sep 3, 2012

Member

typo? should that that be strProtocol2 as the others?

@elupus

elupus Sep 3, 2012

Member

typo? should that that be strProtocol2 as the others?

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

looks like it. will check this, thanks

@opdenkamp

opdenkamp Sep 3, 2012

Member

looks like it. will check this, thanks

@elupus

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Sep 3, 2012

Member

Annoying github not showing diffs on files further down. Anyway:
Key.h changes look scary, it's changing old window id's.

There is clearly some stuff i still don't like in the code. Mainly in dvdplayer.cpp and the interface to the addons for providing data, but I only have myself for blame regarding that since i've not looked at it. But it's nothing blocking a merge.

Some sami subtitle support has snuck in that could be separate.

The key.h header stuff i think needs fixing. Feel like it could break stuff. It's a huge amount of code, but my first scan through the patch is good so I have nothing blocking a merge.

Member

elupus commented Sep 3, 2012

Annoying github not showing diffs on files further down. Anyway:
Key.h changes look scary, it's changing old window id's.

There is clearly some stuff i still don't like in the code. Mainly in dvdplayer.cpp and the interface to the addons for providing data, but I only have myself for blame regarding that since i've not looked at it. But it's nothing blocking a merge.

Some sami subtitle support has snuck in that could be separate.

The key.h header stuff i think needs fixing. Feel like it could break stuff. It's a huge amount of code, but my first scan through the patch is good so I have nothing blocking a merge.

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

@Montellese json-rpc changes have been removed from the PR
@elupus moved the window ids in Key.h around a bit so we don't change existing ids

everything will be squashed up into 1 commit when done

Member

opdenkamp commented Sep 3, 2012

@Montellese json-rpc changes have been removed from the PR
@elupus moved the window ids in Key.h around a bit so we don't change existing ids

everything will be squashed up into 1 commit when done

@Montellese

This comment has been minimized.

Show comment Hide comment
@Montellese

Montellese Sep 3, 2012

Member

@opdenkamp Thanks for the reverts. The project files (VS and XCode) will need updating (i.e. remove the previously added xbmc/interfaces/json-rpc/PVROperations.h/cpp from the project files) but that shouldn't be a big deal.

Member

Montellese commented Sep 3, 2012

@opdenkamp Thanks for the reverts. The project files (VS and XCode) will need updating (i.e. remove the previously added xbmc/interfaces/json-rpc/PVROperations.h/cpp from the project files) but that shouldn't be a big deal.

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

@Montellese indeed. will fix it

Member

opdenkamp commented Sep 3, 2012

@Montellese indeed. will fix it

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

@cptspiff was checking where the deletions were coming from, and noticed that this slipped in: following files were deleted in the pvr branch when i was cleaning things up, which should have been done in mainline:
lib/libhts/Win32/include/stdint.h
lib/libhts/Win32/libhts_2003.sln
lib/libhts/Win32/libhts_2003.vcproj
lib/libhts/Win32/libhts_2008.sln
lib/libhts/Win32/libhts_2008.vcproj

since this is completely unrelated to this PR, i'll re-add the files here and put that in a separate PR (those not being used anymore)

Member

opdenkamp commented Sep 3, 2012

@cptspiff was checking where the deletions were coming from, and noticed that this slipped in: following files were deleted in the pvr branch when i was cleaning things up, which should have been done in mainline:
lib/libhts/Win32/include/stdint.h
lib/libhts/Win32/libhts_2003.sln
lib/libhts/Win32/libhts_2003.vcproj
lib/libhts/Win32/libhts_2008.sln
lib/libhts/Win32/libhts_2008.vcproj

since this is completely unrelated to this PR, i'll re-add the files here and put that in a separate PR (those not being used anymore)

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

@cptspiff re-added project files for libhts in 36825e5. saves a few d's ;-) scrolled through the patch quickly, and most other deletions are things like changed if statements, cases added to switches, etc that hook up the various pvr bits. i'll be happy to explain certain parts you'd like to see explained.

@Montellese removed the refs to the files from the project files. just a quick find and replace, not sure whether the apple stuff needs more than just this.

Member

opdenkamp commented Sep 3, 2012

@cptspiff re-added project files for libhts in 36825e5. saves a few d's ;-) scrolled through the patch quickly, and most other deletions are things like changed if statements, cases added to switches, etc that hook up the various pvr bits. i'll be happy to explain certain parts you'd like to see explained.

@Montellese removed the refs to the files from the project files. just a quick find and replace, not sure whether the apple stuff needs more than just this.

@ghost

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Sep 3, 2012

thanks lars, it was the deleted files i wondered about. that some hunks remove code is less of a concern.

ghost commented Sep 3, 2012

thanks lars, it was the deleted files i wondered about. that some hunks remove code is less of a concern.

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 3, 2012

Member

@elupus the samitagconvertor stuff was merged in from pvr-testing2 earlier, but doesn't seem to be hooked up to anything. it's not even hooked up in the makefiles/project files. so i'll just remove it from the PR.

Member

opdenkamp commented Sep 3, 2012

@elupus the samitagconvertor stuff was merged in from pvr-testing2 earlier, but doesn't seem to be hooked up to anything. it's not even hooked up in the makefiles/project files. so i'll just remove it from the PR.

@Memphiz

This comment has been minimized.

Show comment Hide comment
@Memphiz

Memphiz Sep 4, 2012

Member

Just to confirm. Your changes in removing the PVR JSON stuff from the xcode projects are fine.

Member

Memphiz commented Sep 4, 2012

Just to confirm. Your changes in removing the PVR JSON stuff from the xcode projects are fine.

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 4, 2012

Member

@pieh included the two fixes from irc, thanks

let me know when everybody finished this review, and i'll rebase & squash

Member

opdenkamp commented Sep 4, 2012

@pieh included the two fixes from irc, thanks

let me know when everybody finished this review, and i'll rebase & squash

@elupus

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Sep 4, 2012

Member

When you rebase, would be nice if non english translations where added as a separate commit. (they are not a core requirement)

Member

elupus commented Sep 4, 2012

When you rebase, would be nice if non english translations where added as a separate commit. (they are not a core requirement)

@alanwww1

This comment has been minimized.

Show comment Hide comment
@alanwww1

alanwww1 Sep 4, 2012

Member

@elupus , @opdenkamp

It is not a problem for me to handle the translations. This is why a held back my bulk language file update PR, so that it wouldn't interfere with this PR. If this is merged, I can update Transifex with the new English strings and also the non-English translations as well. Translation groups can than review, or change the as they decide.

So from my side, they can stay in, if there is no other reason to separate.

Member

alanwww1 commented Sep 4, 2012

@elupus , @opdenkamp

It is not a problem for me to handle the translations. This is why a held back my bulk language file update PR, so that it wouldn't interfere with this PR. If this is merged, I can update Transifex with the new English strings and also the non-English translations as well. Translation groups can than review, or change the as they decide.

So from my side, they can stay in, if there is no other reason to separate.

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 4, 2012

Member

@alanwww1 great, thanks for holding back your PR. i can just push in the english strings, or push them all. whichever you prefer. it's an easy change for me

unless someone wants to review the latest changes separately, i'll squash&rebase now. the removals will make github show some more changes without complaining that the pr is too big ;-)

Member

opdenkamp commented Sep 4, 2012

@alanwww1 great, thanks for holding back your PR. i can just push in the english strings, or push them all. whichever you prefer. it's an easy change for me

unless someone wants to review the latest changes separately, i'll squash&rebase now. the removals will make github show some more changes without complaining that the pr is too big ;-)

@alanwww1

This comment has been minimized.

Show comment Hide comment
@alanwww1

alanwww1 Sep 4, 2012

Member

@opdenkamp For me, it would be better to have them all in, so I can merge back the new translations right after it, if that's ok for everyone.

Member

alanwww1 commented Sep 4, 2012

@opdenkamp For me, it would be better to have them all in, so I can merge back the new translations right after it, if that's ok for everyone.

@elupus

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Sep 4, 2012

Member

I never meant leave the translations out. I just meant as a separate commit. This is one huge commit as it is. If it can easily be split that makes it more readable.

Member

elupus commented Sep 4, 2012

I never meant leave the translations out. I just meant as a separate commit. This is one huge commit as it is. If it can easily be split that makes it more readable.

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 4, 2012

Member

@elupus done

Member

opdenkamp commented Sep 4, 2012

@elupus done

opdenkamp pushed a commit that referenced this pull request Sep 4, 2012

Lars Op den Kamp
Merge pull request #1357 from opdenkamp/pvr
[pvr] add PVR and EPG support to XBMC

@opdenkamp opdenkamp merged commit d9d303f into xbmc:master Sep 4, 2012

@jmarshallnz

This comment has been minimized.

Show comment Hide comment
@jmarshallnz

jmarshallnz Sep 5, 2012

Member

I haven't reviewed, but if others are happy with it I'm happy to review the
guilib changes after the fact and fix up anything I don't like in master.
On Sep 5, 2012 12:18 AM, "Lars Op den Kamp" notifications@github.com
wrote:

@elupus https://github.com/elupus done


Reply to this email directly or view it on GitHubhttps://github.com/xbmc/xbmc/pull/1357#issuecomment-8281126.

Member

jmarshallnz commented Sep 5, 2012

I haven't reviewed, but if others are happy with it I'm happy to review the
guilib changes after the fact and fix up anything I don't like in master.
On Sep 5, 2012 12:18 AM, "Lars Op den Kamp" notifications@github.com
wrote:

@elupus https://github.com/elupus done


Reply to this email directly or view it on GitHubhttps://github.com/xbmc/xbmc/pull/1357#issuecomment-8281126.

@ghost

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Sep 5, 2012

On Wed, Sep 5, 2012 at 8:51 PM, jmarshallnz notifications@github.comwrote:

I haven't reviewed, but if others are happy with it I'm happy to review
the
guilib changes after the fact and fix up anything I don't like in master.

good. we merged it 24h ago ;)

ghost commented Sep 5, 2012

On Wed, Sep 5, 2012 at 8:51 PM, jmarshallnz notifications@github.comwrote:

I haven't reviewed, but if others are happy with it I'm happy to review
the
guilib changes after the fact and fix up anything I don't like in master.

good. we merged it 24h ago ;)

@jmarshallnz

This comment has been minimized.

Show comment Hide comment
@jmarshallnz

jmarshallnz Sep 5, 2012

Member

Heh, interwebs in Spain haven't caught up.
On Sep 5, 2012 8:56 PM, "Arne Morten Kvarving" notifications@github.com
wrote:

On Wed, Sep 5, 2012 at 8:51 PM, jmarshallnz <notifications@github.com

wrote:

I haven't reviewed, but if others are happy with it I'm happy to review
the
guilib changes after the fact and fix up anything I don't like in master.

good. we merged it 24h ago ;)


Reply to this email directly or view it on GitHubhttps://github.com/xbmc/xbmc/pull/1357#issuecomment-8309887.

Member

jmarshallnz commented Sep 5, 2012

Heh, interwebs in Spain haven't caught up.
On Sep 5, 2012 8:56 PM, "Arne Morten Kvarving" notifications@github.com
wrote:

On Wed, Sep 5, 2012 at 8:51 PM, jmarshallnz <notifications@github.com

wrote:

I haven't reviewed, but if others are happy with it I'm happy to review
the
guilib changes after the fact and fix up anything I don't like in master.

good. we merged it 24h ago ;)


Reply to this email directly or view it on GitHubhttps://github.com/xbmc/xbmc/pull/1357#issuecomment-8309887.

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Sep 5, 2012

Member

@jmarshallnz i'm pretty sure there will be plenty to review and fix up when you get back ;-) have a nice trip :)

Member

opdenkamp commented Sep 5, 2012

@jmarshallnz i'm pretty sure there will be plenty to review and fix up when you get back ;-) have a nice trip :)

@FernetMenta

This comment has been minimized.

Show comment Hide comment
@FernetMenta

FernetMenta Sep 9, 2012

Member

This interafce overwrites state.time (UpdatePlayState) in dvdplayer. This is not ok for vnsi recordings which use ffmpeg demuxer. They better get the time from demuxer. I don't have a good idea for a clean solution yet.

This interafce overwrites state.time (UpdatePlayState) in dvdplayer. This is not ok for vnsi recordings which use ffmpeg demuxer. They better get the time from demuxer. I don't have a good idea for a clean solution yet.

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Sep 9, 2012

Member
Member

elupus replied Sep 9, 2012

This comment has been minimized.

Show comment Hide comment
@FernetMenta

FernetMenta Sep 9, 2012

Member

ahh ok. So the solution would be that GetTotalTime() should return 0 when playing a recording?

Member

FernetMenta replied Sep 9, 2012

ahh ok. So the solution would be that GetTotalTime() should return 0 when playing a recording?

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Sep 9, 2012

Member
Member

elupus replied Sep 9, 2012

@alanwww1

This comment has been minimized.

Show comment Hide comment
@alanwww1

alanwww1 Oct 15, 2012

Member

@opdenkamp
I can't seem to find where we use this string (#19161)
Cannot this be deleted ?

Thanks!

@opdenkamp
I can't seem to find where we use this string (#19161)
Cannot this be deleted ?

Thanks!

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Oct 15, 2012

Member
Member

opdenkamp replied Oct 15, 2012

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Oct 16, 2012

Member
Member

opdenkamp replied Oct 16, 2012

This comment has been minimized.

Show comment Hide comment
@alanwww1

alanwww1 Oct 16, 2012

Member
Member

alanwww1 replied Oct 16, 2012

@alanwww1

This comment has been minimized.

Show comment Hide comment
@alanwww1

alanwww1 Oct 16, 2012

Member

Hi Lars !

Sorry for bothering again with the language strings. Just another thing I noticed:

Could not 19103 and 19167 be merged ?

Thanks,
Attila

Hi Lars !

Sorry for bothering again with the language strings. Just another thing I noticed:

Could not 19103 and 19167 be merged ?

Thanks,
Attila

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Oct 17, 2012

Member
Member

opdenkamp replied Oct 17, 2012

@FernetMenta

This comment has been minimized.

Show comment Hide comment
@FernetMenta

FernetMenta Mar 23, 2013

Member

@opdenkamp for what reason do we return true here? My recordings stop 10 sec too early: demuxer hits eof, player tries to open next stream, create demuxer fails, player stops.

@opdenkamp for what reason do we return true here? My recordings stop 10 sec too early: demuxer hits eof, player tries to open next stream, create demuxer fails, player stops.

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Mar 23, 2013

Member
Member

elupus replied Mar 23, 2013

This comment has been minimized.

Show comment Hide comment
@FernetMenta

FernetMenta Mar 23, 2013

Member

in dvdplayer: should we move the check for next stream below the lines where it checks for a/v players !HasData?

Member

FernetMenta replied Mar 23, 2013

in dvdplayer: should we move the check for next stream below the lines where it checks for a/v players !HasData?

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Mar 23, 2013

Member
Member

elupus replied Mar 23, 2013

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Mar 23, 2013

Member
Member

elupus replied Mar 23, 2013

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Mar 25, 2013

Member

@FernetMenta no idea really, didn't write this one. but i guess @elupus already answered your questions :)

Member

opdenkamp replied Mar 25, 2013

@FernetMenta no idea really, didn't write this one. but i guess @elupus already answered your questions :)

@bam80

This comment has been minimized.

Show comment Hide comment
@bam80

bam80 Sep 15, 2014

Channels mapping table request:
f73deb8#commitcomment-7766235

bam80 commented on 4e9cb43 Sep 15, 2014

Channels mapping table request:
f73deb8#commitcomment-7766235

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Apr 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment