Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake][windows] require SDK 10.0.14393.0 or higher #13583

Merged
merged 1 commit into from
Feb 25, 2018
Merged

[cmake][windows] require SDK 10.0.14393.0 or higher #13583

merged 1 commit into from
Feb 25, 2018

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Feb 25, 2018

Motivation and Context

report already during project generation that a higher Windows SDK is needed instead of later failing to build because of undefined symbols.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added this to the L 18.0-alpha1 milestone Feb 25, 2018
@Rechi Rechi requested review from Paxxi and afedchin February 25, 2018 17:11
@Paxxi Paxxi merged commit b3937f4 into xbmc:master Feb 25, 2018
@Rechi Rechi deleted the windows/minSDKVersion branch February 25, 2018 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paxxi Paxxi Paxxi approved these changes

@afedchin afedchin afedchin approved these changes

Assignees
No one assigned
Labels
CMake Platform: Windows Platform: WindowsStore Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rechi @Paxxi @afedchin