Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] fix packing binary addons #13626

Merged
merged 2 commits into from
Mar 8, 2018
Merged

[cmake] fix packing binary addons #13626

merged 2 commits into from
Mar 8, 2018

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Mar 8, 2018

Motivation and Context

  • to copy the addon zip to PACKAGE_DIR the zip has to be generated already
  • writing generated addon.xml and settings.xml breaks using the same source directory to build for different platforms

How Has This Been Tested?

compiled some binary addons for Windows (32 and 64 bit)

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added Type: Fix non-breaking change which fixes an issue Component: Binary add-ons CMake v18 Leia labels Mar 8, 2018
@Rechi Rechi added this to the Leia 18.0-alpha2 milestone Mar 8, 2018
@Rechi Rechi requested a review from notspiff March 8, 2018 09:13
@Rechi Rechi merged commit 269733c into xbmc:master Mar 8, 2018
@Rechi Rechi deleted the fixPackingAddons branch March 8, 2018 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notspiff notspiff notspiff approved these changes

Assignees
No one assigned
Labels
CMake Component: Binary add-ons Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rechi @notspiff