[cpluff] link with cpluff instead of loading it dynamic

[Rechi]

Description

Don't load cpluff dynamic, but link against it (shared/static).

Motivation and Context

As Kodi calls cpluff functions on startup there is no reason to lazy load the lib.

How Has This Been Tested?

compiled and runtime tested for windows and linux

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the Code guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the CONTRIBUTING document
• I have added tests to cover my change
• All new and existing tests passed

[notspiff]

looks all good

[MilhouseVH]

Any ideas? http://ix.io/10zf

[FernetMenta]

I get dupe symbols on OSX:

duplicate symbol _hash_insert in:
    /Users/DE213022/progs/src/xbmc/build/build/cpluff/lib/libcpluff.a(hash.o)
    /Users/Shared/xbmc-depends/macosx10.13_x86_64-target-debug/lib/mariadb/libmariadbclient.a(ma_hash.c.o)
duplicate symbol _hash_delete in:
    /Users/DE213022/progs/src/xbmc/build/build/cpluff/lib/libcpluff.a(hash.o)
    /Users/Shared/xbmc-depends/macosx10.13_x86_64-target-debug/lib/mariadb/libmariadbclient.a(ma_hash.c.o)
duplicate symbol _hash_free in:
    /Users/DE213022/progs/src/xbmc/build/build/cpluff/lib/libcpluff.a(hash.o)
    /Users/Shared/xbmc-depends/macosx10.13_x86_64-target-debug/lib/mariadb/libmariadbclient.a(ma_hash.c.o)
duplicate symbol _list_delete in:
    /Users/DE213022/progs/src/xbmc/build/build/cpluff/lib/libcpluff.a(list.o)
    /Users/Shared/xbmc-depends/macosx10.13_x86_64-target-debug/lib/mariadb/libmariadbclient.a(ma_list.c.o)
ld: 4 duplicate symbols for architecture x86_64

[Rechi]

force a rebuild of libcpluff

xbmc/lib/cpluff/libcpluff/Makefile.am

Lines 13 to 14 in 02ae31b

	# the following symbols are clashing with mariadb symbols
	CPPFLAGS += -Dhash_delete=kazlib_hash_delete -Dhash_free=kazlib_hash_free -Dhash_insert=kazlib_hash_insert -Dlist_delete=kazlib_list_delete

[FernetMenta]

worked, thanks
shouldn't this be triggered automatically?

[Rechi]

No as the files at lib/cpluff are not added as dependency to the cmake libcpluff target.