Player: re-add busy dialog on start #13699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FernetMenta
commented
Mar 26, 2018
•
FernetMenta
commented
- brings back busy dialog
- add new event for signalling start of audio and video streams
- fix potential error pop-up in case of videoplayer was stopped.
- move python callback OnPlayback.. to main thread
FernetMenta
added
Type: Improvement
FernetMenta
commented
Mar 26, 2018
| @@ -187,6 +187,7 @@ bool CRetroPlayer::OpenFile(const CFileItem& file, const CPlayerOptions& options | |||
| RegisterWindowCallbacks(); | |||
| SetSpeedInternal(1.0); | |||
| m_callback.OnPlayBackStarted(fileCopy); | |||
| m_callback.OnAVStarted(fileCopy); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
garbear
approved these changes
Mar 27, 2018
|
build errors unrelated |
|
Hi @FernetMenta |
ksooo
added a commit
that referenced
this pull request
Mar 31, 2018
[application][pvr][estuary] Fixes after #13699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.