[Binary Addon] Generic interface provider callback #13706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peak3d
added
Type: Improvement
|
jenkins build this please |
1 similar comment
|
jenkins build this please |
|
OSX64 test failure unrelated |
ksooo
reviewed
Mar 29, 2018
| } | ||
| else if (strcmp(name,"sdk_version") == 0) | ||
| { | ||
| sprintf(buffer, "%d", CXBMCApp::get()->getActivity()->sdkVersion); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
FernetMenta
reviewed
Mar 29, 2018
| namespace ADDON | ||
| { | ||
|
|
||
| char* Interface_General::get_platform_property(void* kodiBase, const char *name) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
jenkins build this please |
peak3d
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Binary addons may need platform specific information to work as expected.
This PR adds a generic Interface provider to the Kodi binary addon system and as an example platform specific interface to some android system propertiesan android system info.
The new interface callback is implemented in kodi::Addon base class, is named GetInterface() and is designated to provide a pointer to a function table.
Min Addon Basel API version was not modified because the change does not affect existing functionality.
Therefore old binary addons should still work after this change
Motivation and Context
Get JNI MediaDrm working in binary addon (Android), because NDK is not working as expected / some functionality is not existant in NDK.
How Has This Been Tested?
Android + DRM encrypted sample streams
Types of change