lirc: redesign, fix #13761

FernetMenta · 2018-04-11T15:03:54Z

Register will land in OptionalsReg

This drops sending command from Kodi to Lirc. I don't think this makes much sense.

xbmc/platform/linux/input/LIRC.cpp

-#ifdef HAVE_INOTIFY
-#include <sys/inotify.h>
-#endif
+#include "lirc_client.h"


lrusak · 2018-04-11T16:18:30Z

Can we register lirc in linux optionals now?

MilhouseVH · 2018-04-11T16:24:08Z

LIRC is working on LibreELEC x86_64 (by which I mean that IR input is being received and processed by Kodi), but it looks like the LIRC system is being reloaded/initialised several times a second: http://ix.io/17xt

On LibreELEC RPi2, LIRC is not working - no inputs are received by Kodi: http://ix.io/17xs

FernetMenta · 2018-04-11T17:54:56Z

@MilhouseVH this version has lirc only registered for X11. Testing until OptionslReg for Linux is merged (other PR). So no surprise that it's not working for PI.
But this log for X11 looks very strange. Looks like something creates one CLirc object after another.

FernetMenta · 2018-04-11T17:55:30Z

Can we register lirc in linux optionals now?

@lrusak the other PR need to go in first.

jenkins4kodi · 2018-04-11T18:10:20Z

@FernetMenta this needs a rebase

xbmc/input/InputManager.h

@@ -45,6 +45,7 @@ class CProfilesManager;
 class CTouchTranslator;
 class IKeymapEnvironment;
 class IWindowKeymap;
+class CLirc;


FernetMenta · 2018-04-11T18:48:25Z

jenkins build this please

xbmc/platform/linux/input/LIRC.h

 #include "threads/Thread.h"
-#include "threads/Event.h"
+#include "input/InputManager.h"


xbmc/platform/linux/input/LIRC.cpp

-#ifdef HAVE_INOTIFY
-#include <sys/inotify.h>
-#endif
+#include "Application.h"


xbmc/platform/linux/input/LIRC.cpp

-  if (!m_bInitialized || !m_used )
-    return;
+  int fd = -1;
+  struct lirc_config *config;


xbmc/platform/linux/input/LIRC.cpp

  {
+    fd = lirc_init("kodi", 0);


xbmc/input/InputManager.h

@@ -353,6 +361,7 @@ class CInputManager : public ISettingCallback,

  std::vector<KODI::KEYBOARD::IKeyboardDriverHandler*> m_keyboardHandlers;
  std::vector<KODI::MOUSE::IMouseDriverHandler*> m_mouseHandlers;
+  std::vector<std::unique_ptr<IInput>> m_inputs;


Rechi · 2018-04-12T06:49:34Z

liblirc-dev build dependency should be added to the docs.

garbear · 2018-04-13T15:06:30Z

@FernetMenta FernetMenta#470

garbear

Good to go after squashing my squashme's into your commit.

FernetMenta · 2018-04-14T06:51:28Z

now lirc is completely independent from InputManager

FernetMenta · 2018-04-14T07:07:42Z

@popcornmix @MilhouseVH could you test this on pi please?
@pkerling not sure where you would like to register lirc on Wayland

lrusak · 2018-04-14T07:28:18Z

@FernetMenta thanks for doing the gbm lirc registration 👍

xbmc/platform/linux/OptionalsReg.h

+{
+class CLircContainer;
+CLircContainer* LircRegister();
+void LircUnregister();


yol · 2018-04-14T07:33:24Z

@FernetMenta Do you see a reason for not doing it like the other windowing systems?

I personally don't get why windowing has to deal with lirc at all, for me it's more of a platform thing.

FernetMenta · 2018-04-14T07:38:05Z

Do you see a reason for not doing it like the other windowing systems?

nope but Wayland has a lot more members. should I add it to the end?

I personally don't get why windowing has to deal with lirc at all, for me it's more of a platform thing.

a headless system does not need a remote control like lirc.

yol · 2018-04-14T07:44:23Z

nope but Wayland has a lot more members. should I add it to the end?

Don't think there's any similar members at the moment, so yes that would be alright.

a headless system does not need a remote control like lirc.

Of course, but that does not make lirc the responsibility of the win system :-) Win systems in Kodi already deal with way too much stuff.

MilhouseVH · 2018-04-14T08:26:18Z

RPi is working now, thanks, but messages are split over two lines: http://ix.io/17Jq

For example:

09:19:47.849 T:1864364928   DEBUG: LIRC: - NEW 6c 0 KEY_DOWN devinput
                                             (KEY_DOWN)
09:19:47.854 T:1941860368   DEBUG: HandleKey: 167 (0xa7, obc88) pressed, action is Down

Is this intentional?

Not sure what the errors at the end are about, probably something to do with #13754 - will report it there.

X86_64 still has the LIRC restart issue: http://ix.io/17Ju

MilhouseVH · 2018-04-14T08:40:02Z

I restarted kodi (systemctl stop kodi, waited 5-10 seconds, systemctl start kodi) on x86_64 and it's stuck on the Kodi splash: http://ix.io/17Jx

eventlircd is stuck at 100% CPU:

Rebooting will allow Kodi to start successfully. This seems to be reproducible.

FernetMenta · 2018-04-14T10:56:21Z

jenkins build this please

xbmc/AppParamParser.cpp

@@ -98,10 +98,6 @@ void CAppParamParser::DisplayHelp()
  printf("\t\t\tenables network settings.\n");
  printf("  -p or --portable\t%s will look for configurations in install folder instead of ~/.%s\n", CSysInfo::GetAppName().c_str(), lcAppName.c_str());
  printf("  --legacy-res\t\tEnables screen resolutions such as PAL, NTSC, etc.\n");
-#ifdef HAS_LIRC
-  printf("  -l or --lircdev\tLircDevice to use default is " LIRC_DEVICE " .\n");


FernetMenta · 2018-04-15T08:38:43Z

jenkins build this please

FernetMenta · 2018-04-15T10:53:38Z

build error (test suite) not related

gelotus · 2018-04-20T21:19:59Z

No love for aml?

fritsch · 2018-04-21T08:05:05Z

@gelotus why not PR this minimal piece of code needed? Like: https://pastebin.com/dMikf9z1

Remove lirc parser after #13761

[aml]Register lirc in AML after #13761

app-misc/inputlircd is no longer necessary, see xbmc/xbmc#13761 app-pda/libplist does not require the "python" use flag Signed-off-by: Craig Andrews <candrews@gentoo.org> Package-Manager: Portage-2.3.51, Repoman-2.3.11

FernetMenta added the v18 Leia label Apr 11, 2018

Rechi reviewed Apr 11, 2018

View reviewed changes

xbmc/platform/linux/input/LIRC.cpp Outdated

#ifdef HAVE_INOTIFY

#include <sys/inotify.h>

#endif

#include "lirc_client.h"

This comment was marked as spam.

Sign in to view

jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Apr 11, 2018

afedchin reviewed Apr 11, 2018

View reviewed changes

xbmc/input/InputManager.h Outdated

@@ -45,6 +45,7 @@ class CProfilesManager;

class CTouchTranslator;

class IKeymapEnvironment;

class IWindowKeymap;

class CLirc;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

FernetMenta force-pushed the lirc branch 2 times, most recently from d116f23 to 5535269 Compare April 11, 2018 18:46

FernetMenta removed the Rebase needed PR that does not apply/merge cleanly to current base branch label Apr 11, 2018

garbear reviewed Apr 11, 2018

View reviewed changes

xbmc/platform/linux/input/LIRC.h Outdated

#include "threads/Thread.h"

#include "threads/Event.h"

#include "input/InputManager.h"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

garbear reviewed Apr 11, 2018

View reviewed changes

Rechi reviewed Apr 11, 2018

View reviewed changes

afedchin reviewed Apr 12, 2018

View reviewed changes

garbear mentioned this pull request Apr 13, 2018

Changes for LIRC redesign FernetMenta/xbmc#470

Merged

garbear approved these changes Apr 13, 2018

View reviewed changes

fritsch mentioned this pull request Apr 14, 2018

have ServiceBroker return a pointer for WinSystem #13748

Merged

FernetMenta force-pushed the lirc branch 2 times, most recently from 9a9ee81 to 98a660c Compare April 14, 2018 06:50

FernetMenta added the Type: Improvement non-breaking change which improves existing functionality label Apr 14, 2018

yol reviewed Apr 14, 2018

View reviewed changes

xbmc/platform/linux/OptionalsReg.h Outdated

{

class CLircContainer;

CLircContainer* LircRegister();

void LircUnregister();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

FernetMenta force-pushed the lirc branch from 5f35e50 to b8c43cc Compare April 14, 2018 07:32

FernetMenta force-pushed the lirc branch from b8c43cc to 6a0248f Compare April 14, 2018 09:42

FernetMenta commented Apr 15, 2018

View reviewed changes

FernetMenta added 5 commits April 15, 2018 10:36

lirc: redesign

6e156be

lic: add liblirc-dev to docs

871d59c

rpi: register lirc

9f54a5b

gbm: register lirc

3b875a1

wayland: register lirc

bac44c4

FernetMenta force-pushed the lirc branch from 6a0248f to bac44c4 Compare April 15, 2018 08:37

FernetMenta merged commit 50f98ab into xbmc:master Apr 15, 2018

Rechi added this to the Leia 18.0-alpha2 milestone Apr 15, 2018

gelotus added a commit to gelotus/xbmc that referenced this pull request Apr 21, 2018

Remove lirc parser after xbmc#13761

9c0c494

gelotus added a commit to gelotus/xbmc that referenced this pull request Apr 21, 2018

[aml][wip] Register lirc in AML after xbmc#13761

9d48f03

FernetMenta added a commit that referenced this pull request Apr 21, 2018

Merge pull request #13797 from gelotus/Remove-dead-code

19c9d0a

Remove lirc parser after #13761

gelotus added a commit to gelotus/xbmc that referenced this pull request Apr 21, 2018

[AML]Register Lirc after xbmc#13761

e5bc388

gelotus added a commit to gelotus/xbmc that referenced this pull request May 1, 2018

[aml]Register lirc in AML after xbmc#13761

a83e50f

FernetMenta added a commit that referenced this pull request May 1, 2018

Merge pull request #13798 from gelotus/amlogic-lirc

3a989ee

[aml]Register lirc in AML after #13761

DaVukovic pushed a commit to DaVukovic/xbmc that referenced this pull request Jun 5, 2018

[aml]Register lirc in AML after xbmc#13761

2683362

chadparry mentioned this pull request May 7, 2020

Not working under Kodi 18.4 & Debian 10 chadparry/kodi-plugin.program.remote.control.browser#5

Closed

lirc: redesign, fix #13761

lirc: redesign, fix #13761

Conversation

FernetMenta commented Apr 11, 2018

This comment was marked as spam.

lrusak commented Apr 11, 2018

MilhouseVH commented Apr 11, 2018

FernetMenta commented Apr 11, 2018

FernetMenta commented Apr 11, 2018

jenkins4kodi commented Apr 11, 2018

This comment was marked as spam.

This comment was marked as spam.

FernetMenta commented Apr 11, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Rechi commented Apr 12, 2018

garbear commented Apr 13, 2018 • edited Loading

garbear left a comment

Choose a reason for hiding this comment

FernetMenta commented Apr 14, 2018

FernetMenta commented Apr 14, 2018

lrusak commented Apr 14, 2018

This comment was marked as spam.

This comment was marked as spam.

yol commented Apr 14, 2018

FernetMenta commented Apr 14, 2018

yol commented Apr 14, 2018

MilhouseVH commented Apr 14, 2018

MilhouseVH commented Apr 14, 2018

FernetMenta commented Apr 14, 2018

This comment was marked as spam.

FernetMenta commented Apr 15, 2018

FernetMenta commented Apr 15, 2018

gelotus commented Apr 20, 2018

fritsch commented Apr 21, 2018 • edited Loading

garbear commented Apr 13, 2018 •

edited

Loading

fritsch commented Apr 21, 2018 •

edited

Loading