Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] remote control re-design. #13778

Merged
merged 3 commits into from
Apr 18, 2018
Merged

Conversation

afedchin
Copy link
Member

see commits

@afedchin afedchin added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Platform: Windows v18 Leia Platform: WindowsStore labels Apr 17, 2018
@afedchin afedchin added this to the Leia 18.0-alpha2 milestone Apr 17, 2018
@@ -182,6 +185,11 @@ void CWinEventsWin10::InitEventHandlers(CoreWindow^ window)
m_smtc->IsEnabled = true;
CAnnouncementManager::GetInstance().AddAnnouncer(this);
}
if (CSysInfo::GetWindowsDeviceFamily() == CSysInfo::WindowsDeviceFamily::Xbox)
{
m_remote = std::make_unique<CRemoteControlXbox>();

This comment was marked as spam.

This comment was marked as spam.

Copy link
Contributor

@FernetMenta FernetMenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

Copy link
Member

@garbear garbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good reduction of our maintenance burden

@afedchin afedchin merged commit b3a4aed into xbmc:master Apr 18, 2018
@afedchin afedchin deleted the win-remotes branch April 18, 2018 07:00
int iAttempt = 0;
m_profileId = CServiceBroker::GetProfileManager().GetCurrentProfileId();
m_irTranslator.Load(IRSS_MAP_FILENAME);

// try to connect 60 times @ a 5 second interval (5 minutes)

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Windows Platform: WindowsStore Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants