Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guiinfo] Fix PLAYER_TITLE fallbacks. #13786

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Apr 18, 2018

Fixes a regression introduced with #13754

Reported in the forum: https://forum.kodi.tv/showthread.php?tid=298461&pid=2726685#pid2726685

PLAYER_TITLE fallback handling (tag title -> item label -> filename) was broken.

@MilhouseVH fyi

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: GUI engine v18 Leia labels Apr 18, 2018
@ksooo ksooo added this to the Leia 18.0-alpha2 milestone Apr 18, 2018
@ksooo ksooo requested a review from Jalle19 April 18, 2018 12:27
@MilhouseVH
Copy link
Contributor

Looks good now, issue is fixed - thanks!

@ksooo ksooo merged commit 16abdf8 into xbmc:master Apr 18, 2018
@ksooo ksooo deleted the guiinfo-fix-player-title branch April 18, 2018 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GUI engine Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants