Replace global color_t type with UTILS::Color. #13787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
force-pushed
the
replace-color-t-type
branch
4 times, most recently
from
fd90ef4
to
5bcf9fc
Compare
ksooo
changed the title
ksooo
force-pushed
the
replace-color-t-type
branch
from
5bcf9fc
to
f8abf1a
Compare
ksooo
force-pushed
the
replace-color-t-type
branch
from
f8abf1a
to
4cb70c7
Compare
|
As discussed internally with @notspiff, this one is ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining our own
color_tin global namespace recently led to build breakers on Windows when compiling using VS 2015. This PR removescolor_tcompletely from our code base and replaces it with the new typeUTILS::Color.@Rechi @peak3d f.y.i.