-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[depends][darwin] cleanup, fix variable order & build / host mix up #13816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Jenkins doesn’t seem to like something about it though (only on phone - can’t check the compile output).
This definitely changes some Behavior for libffi - but I guess those libffi hacks are not needed anymore - same for GMP
Approved - once Jenkins builds it...
tools/depends/target/gmp/Makefile
Outdated
@@ -19,10 +19,10 @@ ifeq ($(OS),linux) | |||
endif | |||
|
|||
ifeq ($(OS),ios) | |||
CONFIGURE_FLAGS=CC_FOR_BUILD=llvm-gcc CPP_FOR_BUILD="llvm-gcc -E" --disable-assembly | |||
CONFIGURE_FLAGS=CC_FOR_BUILD="$(CC_FOR_BUILD)" CPP_FOR_BUILD="$(CC_FOR_BUILD) -E" --disable-assembly |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@Memphiz jenkins succeeded now, maybe you want to look at the changes again. |
Mhh OSX-64 failed? |
Test suite only (TestEvent.GroupTimedWait), but will do another jenkins run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appart from that - fine by me - thx :)
Nice work! iphoneos11.3_arm64 build was giving me problems before this with default sdk. Tested this PR on 10.13.4 (x64, x32 and iOS arm64 clean builds). Apart from the usual shenanigans of having to run Going to do a round of Kodi builds to test the rest. 🤞 Thanks! |
Description
-mmacosx-version-min
should be in native cflags for all build on osx, no matter what the target platform isac_cv_*
settings in native config.siteTypes of change
Checklist: