Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] save resume points on exit #13822

Merged
merged 1 commit into from Apr 28, 2018
Merged

[fix] save resume points on exit #13822

merged 1 commit into from Apr 28, 2018

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Apr 28, 2018

Description

saving resume points is done with a job, so it has to happen before all jobs are cancelled

Motivation and Context

fixes https://trac.kodi.tv/ticket/17757

How Has This Been Tested?

started a video, exited kodi without stopping the file, restarted kodi and checked resume point

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added Type: Fix non-breaking change which fixes an issue Component: Video v18 Leia labels Apr 28, 2018
@Rechi Rechi added this to the Leia 18.0-alpha2 milestone Apr 28, 2018
@FernetMenta
Copy link
Contributor

this will break again. better make saveFileState independent from jobManager. you can check if running on a job succeeds. if not, run it on the calling thread.

saving resume points is done with a job, so it has to happen before all jobs are cancelled
@Rechi
Copy link
Member Author

Rechi commented Apr 28, 2018

confirmed by @FernetMenta that it can be merged, as playback shouldn't be stopped that late

@Rechi Rechi merged commit 94737c2 into xbmc:master Apr 28, 2018
@Rechi Rechi deleted the fix/resumePoint branch April 28, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants