VAAPI: add vp8 support #13843
Merged
VAAPI: add vp8 support #13843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does this work reliable for all vp8 files? |
|
I haven't had any issues yet, most of my vp8 files are just videos I've downloaded from youtube using youtube-dl |
|
The background of my question: we have settings to disable codecs supported by vaapi (all but h.264). IMO it would make sense making vp8 configurable too. |
|
should I do it for vp9 also? |
lrusak
force-pushed
the
vp8-vaapi
branch
2 times, most recently
from
384efac
to
df3ef2c
Compare
|
I can PR the vp9 commit separately if desired |
FernetMenta
approved these changes
May 5, 2018
FernetMenta
reviewed
May 5, 2018
| @@ -121,6 +121,8 @@ class CSettings : public CSettingsBase, public CSettingCreator, public CSettingC | |||
| static const std::string SETTING_VIDEOPLAYER_USEVAAPIMPEG2; | |||
| static const std::string SETTING_VIDEOPLAYER_USEVAAPIMPEG4; | |||
| static const std::string SETTING_VIDEOPLAYER_USEVAAPIVC1; | |||
| static const std::string SETTING_VIDEOPLAYER_USEVAAPIVP8; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
tested both settings and they are working properly on gemini lake. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used on Gemini lake hardware
Kodi log: http://ix.io/19fI
vainfo relevance: