Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[win10] bump minimal required SDK version to 10.0.16299 #13849

Merged
merged 9 commits into from
May 5, 2018

Conversation

afedchin
Copy link
Member

@afedchin afedchin commented May 3, 2018

Bump minimal required Windows SDK version to 10.0.16299

Description

10.0.16299 SDK provides more WinAPI functions: pipes support, environment variables and others see https://docs.microsoft.com/en-us/uwp/win32-and-com/win32-apis.
Kodi uses workaround for getenv method via Local Settings, with this update we can drop it.
Python now has subprocess module. It was impossible to compile it with old SDK.
and other cosmetics fixes.

Some dependencies were re-built with new SDK because some of WinAPI is accessed now and some workarounds were removed.

CONS
Now it's not possible to install Kodi on Windows 10 Mobile because the last released version is 10.0.15254.369 (April 2018)
I've updated ARM packages to keep them in the same state as for x86/x64.
@Rechi I think the WIN-UWP-ARM job can be disabled now because it has no sense. We can enable it again if MS will ever release 16299 build for mobile system

Motivation and Context

How Has This Been Tested?

Tested x64 build in run-time and with WACK utility.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@afedchin
Copy link
Member Author

afedchin commented May 3, 2018

@notspiff @Rechi let me know if I missed some add-ons for dependencies updates.

@@ -756,7 +755,6 @@ bool CCPUInfo::readProcStat(unsigned long long& user, unsigned long long& nice,
}
catch (...)

This comment was marked as spam.

This comment was marked as spam.

@afedchin
Copy link
Member Author

afedchin commented May 4, 2018

jenkins build this please

@afedchin afedchin merged commit cea8b1e into xbmc:master May 5, 2018
@afedchin afedchin deleted the win10-bump-sdk branch May 5, 2018 11:08
@afedchin afedchin added this to the Leia 18.0-alpha2 milestone May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: WindowsStore Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants