-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[win10] bump minimal required SDK version to 10.0.16299 #13849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2018
Rechi
reviewed
May 3, 2018
xbmc/utils/CPUInfo.cpp
Outdated
@@ -756,7 +755,6 @@ bool CCPUInfo::readProcStat(unsigned long long& user, unsigned long long& nice, | |||
} | |||
catch (...) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Platform: WindowsStore
Type: Improvement
non-breaking change which improves existing functionality
v18 Leia
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump minimal required Windows SDK version to
10.0.16299
Description
10.0.16299 SDK provides more WinAPI functions: pipes support, environment variables and others see https://docs.microsoft.com/en-us/uwp/win32-and-com/win32-apis.
Kodi uses workaround for getenv method via Local Settings, with this update we can drop it.
Python now has
subprocess
module. It was impossible to compile it with old SDK.and other cosmetics fixes.
Some dependencies were re-built with new SDK because some of WinAPI is accessed now and some workarounds were removed.
CONS
Now it's not possible to install Kodi on Windows 10 Mobile because the last released version is
10.0.15254.369
(April 2018)I've updated ARM packages to keep them in the same state as for x86/x64.
@Rechi I think the
WIN-UWP-ARM
job can be disabled now because it has no sense. We can enable it again if MS will ever release 16299 build for mobile systemMotivation and Context
How Has This Been Tested?
Tested x64 build in run-time and with WACK utility.
Screenshots (if appropriate):
Types of change
Checklist: