Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution: User current resolution - desktop might be something else #13868

Merged
merged 1 commit into from May 11, 2018

Conversation

fritsch
Copy link
Member

@fritsch fritsch commented May 10, 2018

The former fix assumed that RES_DESKTOP would always be the kodi resolution which is not the case. Therefore let's use the current resolution when doing a fallback.

@lrusak
Copy link
Contributor

lrusak commented May 10, 2018

If this fixes it for you then merge away 👍👍👍

@fritsch
Copy link
Member Author

fritsch commented May 10, 2018

We have time :-) Can you reproduce?

Set kodi to 1920x1080 (or 1280x720)
Allow 3840x2160 (or 1920x1080) in white list with 50 hz each
Now play 576i50

Before: it should switch up to 3840x2160 (or 1920x1080)
After: it should stay at 1920x1080 (or 1280x720)

Whatever you have set above.

Copy link
Contributor

@lrusak lrusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working 👍

@fritsch
Copy link
Member Author

fritsch commented May 11, 2018

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 10f2044 into xbmc:master May 11, 2018
@iz8mbw
Copy link

iz8mbw commented May 11, 2018

Thanks for that!!!!

@Rechi Rechi added Type: Fix non-breaking change which fixes an issue v18 Leia labels May 11, 2018
@Rechi Rechi added this to the Leia 18.0-alpha2 milestone May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants