LinuxRendererGLES: consolidate custom renderers

[lrusak]

This is mostly dead code. Let's do what the GL renderer did.

The comment about CVREF render method indicates that this may break it.

[Memphiz]

So what is your Intention in Breaking CoreVideo Rendercapture? Not sure what I should review on that - that comment is there for a reason I am pretty sure. Now we have an extra y flip for corevideo references.
If you want me to test this change by doing a screenshot with this commit applied - I can do so of course. But if nothing else changed behaviour before - this will result in an upside down screenshot when using vtb video acceleration.

[FernetMenta]

That comment is from a time before I rewrote vtb, isn‘t it? Further it is not rendering but rendercapture

[Memphiz]

In have adapted my comment ...

[FernetMenta]

If vtb needs different code, it should be done in vtb, not generic gles. This was the idea of rework of renderers

[lrusak]

Of course my intention isn't to break it. I would like to fix it properly if it needs fixing.

[Memphiz]

@lrusak it doesn't compile:

http://jenkins.kodi.tv/job/IOS-ARM64/4782/console

in case you find an easy compile fix by looking at the log - please trigger jenkins for another test build for me to test. While trying to compile current master here yesterday - i realised that i need xcode9 now due to thread local storage changes. At that time my free time was over. ;)

[Memphiz]

So i tried this by generating bookmarks while playing via VTB (using VideoCoreRef)

Nightly build: - bookmark is correctly oriented
This PR (+ the compile fix): bookmark looks correctly orientated.
This PR (+ the compile fix) with the y flip commented out: upside down bookmark

So i guess something changed somewhere that makes the rotation mandatory for VTB / VCREF too. Just wondering why nightly had the correct orientation then - because it had the flip skipped for VCREF ...

All fine then i guess.

[lrusak]

@Memphiz really great! thanks for testing 👍

[Memphiz]

One once it compiles :)