Yet more include cleanups #14036
Merged
Yet more include cleanups #14036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you order the includes lexicographical. I know they aren't consistent everywhere, but at least try to not mess up more then it is already. |
|
Most of my code uses lexicographical order with directories before files, it doesn't really matter just try to be consistent with what is already in the file. |
|
@Rechi found the code guideline describing that; I'll fix my patches and re-push. |
Hide the `g_langInfo` access inside the new static method `GetOriginalLocale()` to avoid this heavy header dependency.
|
Rebased and sorted includes according to code guideline. |
MartijnKaijser
added
Type: Cleanup
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.