Resolution: Allow 3:2 pulldown and next integer and doubled upper integer #14077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine. My only suggestion is to add logging in between the selections like there is above. This makes it easier to know what's going on and what's being tried/matched |
FernetMenta
reviewed
Jun 18, 2018
| @@ -168,6 +168,71 @@ void CResolutionUtils::FindResolutionFromWhitelist(float fps, int width, bool is | |||
| } | |||
| } | |||
|
|
|||
| // Allow 3:2 pull down | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
FernetMenta
reviewed
Jun 18, 2018
| } | ||
| } | ||
|
|
||
| // Allow next upper integer refreshrate - some computers, like the MAC don't have fractional refreshrates - those refreshrate |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
FernetMenta
reviewed
Jun 18, 2018
| } | ||
| } | ||
|
|
||
| // And finally to help people to get 29.97i to 60 hz |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
see my comments. exceptions must be limited to known cases. we don't want any undesired magic elsewhere. |
Rechi
reviewed
Aug 5, 2018
| const RESOLUTION_INFO desktop_info = CServiceBroker::GetWinSystem()->GetGfxContext().GetResInfo(CDisplaySettings::GetInstance().GetCurrentResolution()); | ||
|
|
||
| if (info.iScreenWidth == desktop_info.iWidth && | ||
| info.iScreen == desktop_info.iScreen && |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@Memphiz if you have some time to finish this :) |
|
Done ;) - this is not an accepted solution. Bringing the passthrough dependency into the equation is neither. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new whitelisted refresh rate approach changed behaviour in a way that results in a regression for macOS users. macOS has no fractional rates. So those users depend on automated switching to 24hz for 23.xx FPS content and tend to use sync to display in addition.
This change restores that refreshrate matching behaviour.
23.xx matches to 24hz
29.xx matches to 30hz or 60hz
Motivation and Context
Regression reported in https://forum.kodi.tv/showthread.php?tid=332653
How Has This Been Tested?
User gb160 confirmed the fix
Thx @fritsch for the code.
Types of change
Checklist: